Skip to content

[verification] Exercise generator required gate#4157

Closed
justin808 wants to merge 1 commit into
mainfrom
jg-codex/issue-4150-ci-required-exercise
Closed

[verification] Exercise generator required gate#4157
justin808 wants to merge 1 commit into
mainfrom
jg-codex/issue-4150-ci-required-exercise

Conversation

@justin808

@justin808 justin808 commented Jun 21, 2026

Copy link
Copy Markdown
Member

Verification-only PR

This draft PR exists only to collect evidence for issue #4150 after PR #4149 changed .github/workflows/ci-required.yml.

Do not merge this PR. After the required evidence is captured, this PR should be closed and the temporary branch may be deleted.

Why

The issue needs a real ordinary pull_request run proving that generator-sensitive changes fail ci-required / required-pr-gate before hosted CI is requested, then pass after hosted CI is requested with the auditable +ci-run-hosted path.

Implementation

  • Adds one verification-only comment under react_on_rails/spec/react_on_rails/generators/.
  • The file path is intentionally generator-sensitive so script/ci-changes-detector origin/main emits run_generators=true.
  • No workflow files are edited.

Validation

  • git diff --check - passed.
  • script/ci-changes-detector origin/main - passed; output includes run_generators=true.
  • (cd react_on_rails && bundle exec rspec spec/react_on_rails/generators/generator_messages_spec.rb) - 59 examples, 0 failures.
  • (cd react_on_rails && BUNDLE_GEMFILE=../Gemfile bundle exec rubocop) - 226 files inspected, no offenses detected.
  • codex review --base origin/main - no actionable findings.
  • pre-commit hook - passed.
  • pre-push hook - passed.

CI Exercise Plan

  1. Leave this PR without ready-for-hosted-ci first and capture the expected ci-required / required-pr-gate failure.
  2. Comment +ci-status, then +ci-run-hosted.
  3. Capture the required gate passing and hosted generator checks for the same head SHA.
  4. Close this PR without merging and report the evidence on Follow-up: Exercise GitHub Actions changes from PR #4149 #4150.

Labels

Labels: none initially. This is intentional so the ordinary PR required-gate failure path is exercised before hosted CI is requested.


Note

Low Risk
Comment-only edit in a generator spec for CI evidence collection; no runtime, auth, or workflow logic changes.

Overview
Verification-only change — not intended to merge. Adds a single comment in generator_messages_spec.rb under react_on_rails/spec/react_on_rails/generators/ so script/ci-changes-detector sets run_generators=true and a normal pull_request can prove the post-#4149 ci-required / required-pr-gate behavior (fail before hosted CI is requested, pass after +ci-run-hosted).

No workflow or generator implementation changes; behavior of the spec suite is unchanged aside from the comment.

Reviewed by Cursor Bugbot for commit 1257fe7. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: deec60ac-fa12-40c6-9858-3a107c4338b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/issue-4150-ci-required-exercise

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member Author

+ci-status

@github-actions

Copy link
Copy Markdown
Contributor

CI Status

Head SHA: 1257fe707a36
Changed files: 1
Docs-only heuristic (matches ci-changes-detector metadata paths): no
ready-for-hosted-ci label: absent
force-full-hosted-ci label: absent
Current hosted-CI waiver: not present for this SHA

Only the required gate is active unless hosted CI is requested.

Copy link
Copy Markdown
Member Author

+ci-run-hosted

require_relative "../support/generator_spec_helper"

describe GeneratorMessages do
# Verification-only touch for #4150: this short-lived PR exercises generator-sensitive CI gating.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is intentional scaffolding for the CI exercise and is fine here during the PR's lifetime. However, it contains PR-specific language ("this short-lived PR") and an issue reference that will become stale the moment this branch is deleted. It should be removed — or this file should not be merged — before anything lands in main.

Suggested change
# Verification-only touch for #4150: this short-lived PR exercises generator-sensitive CI gating.

@github-actions github-actions Bot added the ready-for-hosted-ci Run optimized hosted GitHub CI for this PR label Jun 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hosted CI Requested

Triggered 9 workflow(s) for 1257fe707a36.
Mode: optimized hosted CI (path-selected by script/ci-changes-detector).
Added ready-for-hosted-ci, so future commits will keep running optimized hosted CI until +ci-stop-hosted is used.

View progress in the Actions tab.

@claude

claude Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Code Review

Status: Verification-only / draft — no functional changes to review.

Overview

This PR adds a single comment to generator_messages_spec.rb to trigger run_generators=true in script/ci-changes-detector, providing a real pull_request event to validate the post-#4149 ci-required / required-pr-gate behavior (fail before hosted CI is requested, pass after +ci-run-hosted). The PR description is clear and well-structured.

Change Quality

  • Safe: The diff is comment-only with zero runtime impact. RuboCop passes, 59 RSpec examples pass.
  • Correctly scoped: The file path is intentionally generator-sensitive for the CI exercise.
  • Pre-checks verified: git diff --check, RuboCop, RSpec, and pre-commit/pre-push hooks all passed per the PR description.

One concern: the comment must not land in main

The added line contains PR-specific prose ("this short-lived PR", issue reference #4150). This is appropriate as evidence scaffolding but not as permanent codebase content — it would rot immediately after this branch is deleted. The PR is already marked "Do not merge", which is the right call.

If this branch is ever repurposed, the comment on line 8 should be removed before merging.

Verdict

The change fulfils its stated purpose correctly. Close without merging once the CI evidence is captured, as planned.

@justin808 justin808 added ready-for-hosted-ci Run optimized hosted GitHub CI for this PR and removed ready-for-hosted-ci Run optimized hosted GitHub CI for this PR labels Jun 21, 2026
@cursor

cursor Bot commented Jun 21, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_787a3dab-3976-4999-8cc3-f0d90d74e52a)

@justin808

Copy link
Copy Markdown
Member Author

Closing this verification-only PR after #4150 evidence was captured. This PR must not be merged.

@justin808 justin808 closed this Jun 21, 2026
@justin808 justin808 deleted the jg-codex/issue-4150-ci-required-exercise branch June 21, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-hosted-ci Run optimized hosted GitHub CI for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant