Skip to content

Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX#4735

Open
justin808 wants to merge 1 commit into
mainfrom
docs/adr-0002-agent-toolchain
Open

Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX#4735
justin808 wants to merge 1 commit into
mainfrom
docs/adr-0002-agent-toolchain

Conversation

@justin808

@justin808 justin808 commented Jul 18, 2026

Copy link
Copy Markdown
Member

Why

The #4605 maintainer decision (2026-07-17) settled how React on Rails ships its agent toolchain for 17.2, but the planning glossary (internal/planning/CONTEXT.md) still described Agent-native development with MCP as a presumed delivery vehicle, and the decision's trade-off (Skills-in-package vs slim MCP vs docs-only, after #3870's full-MCP rejection) met the bar for a decision record: hard to reverse (Skills become shipped package surface), surprising without context, and a real trade-off.

What

Test plan

  • Prettier clean on both files
  • Internal-docs-only change (internal/ is not published); no runtime, CI, or published-docs surface

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Documented the decision to provide version-matched AI agent skills and bundled documentation with React on Rails packages.
    • Clarified that agents can work end-to-end without external setup through packaged guidance, project instructions, and machine-readable errors.
    • Recorded that a slim MCP integration is deferred pending evaluation results.

Captures the 2026-07-17 maintainer decision on #4605: Skills-in-package
plus version-matched bundled docs are the 17.2 agent flagship; a slim
MCP stays deferred until the #4603 eval produces evidence. Updates the
Agent-native development glossary entry that still presumed MCP as the
delivery vehicle.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44809b88-e4ee-4211-832b-2d4dd755b2cd

📥 Commits

Reviewing files that changed from the base of the PR and between a33d163 and 7dba7a1.

📒 Files selected for processing (2)
  • internal/adr/0002-skills-in-package-over-mcp.md
  • internal/planning/CONTEXT.md

Walkthrough

Changes

Agent delivery policy

Layer / File(s) Summary
Skills-in-package decision and planning alignment
internal/adr/0002-skills-in-package-over-mcp.md, internal/planning/CONTEXT.md
Adds the 17.2 Skills-in-package decision with version-matched bundled docs, defers slim MCP pending evaluation evidence, and updates agent-native development guidance accordingly.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

  • #4605 — Directly covers the in-package Skills, version-matched bundled docs, and deferred slim MCP proposal documented by this change.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main documentation change: ADR 0002 choosing Skills-in-package over MCP for agent-native DX.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-0002-agent-toolchain

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown

Greptile Summary

This PR records the agent-toolchain decision for the 17.2 release. The main changes are:

  • Adds ADR 0002 for package-bundled Skills and version-matched documentation.
  • Defers a slim MCP until the agent evaluation provides supporting evidence.
  • Aligns the planning glossary and ambiguity log with the decision.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed documentation.
  • The ADR follows the existing structure and its relative links resolve.
  • The planning updates consistently describe the accepted 17.2 direction.

Important Files Changed

Filename Overview
internal/adr/0002-skills-in-package-over-mcp.md Adds an accepted ADR with the decision, alternatives, consequences, and revisit conditions.
internal/planning/CONTEXT.md Updates the agent-native development theme and resolved-ambiguity log to reference ADR 0002.

Reviews (1): Last reviewed commit: "Docs: record agent-toolchain v2 decision..." | Re-trigger Greptile

@claude

claude Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review

Scope: internal-docs-only change (2 files, +23/-1), no runtime/CI/published-docs surface. Reviewed for correctness, convention adherence, and internal consistency.

Overview

Adds internal/adr/0002-skills-in-package-over-mcp.md, recording the #4605 decision that React on Rails' 17.2 agent toolchain ships as Skills-in-package + version-matched bundled docs, with a slim MCP deferred pending #4603 eval evidence. Updates internal/planning/CONTEXT.md's Agent-native development glossary entry to match and logs the resolved ambiguity.

Code quality / convention

  • The new ADR follows the exact structural convention established by 0001-rspack-answers-vite.md (frontmatter with status/date, title, prose rationale, "Considered options", "Consequences" with an explicit revisit trigger). Nice consistency.
  • The CONTEXT.md edit is minimal and surgical: updates one glossary entry, adds an _Avoid_ line (matching the pattern used by other entries in the file), and appends one line to "Flagged ambiguities" — all consistent with the file's existing structure.
  • Cross-link [ADR 0002](../adr/0002-skills-in-package-over-mcp.md) resolves correctly relative to internal/planning/CONTEXT.mdinternal/adr/0002-...md.

Issues / risks

None found. This is a low-risk, well-scoped documentation change:

Suggestions (optional, non-blocking)

Overall: clean, well-structured decision record that matches this repo's existing ADR conventions. No blocking concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant