Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions prototypes/docusaurus/docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const config: Config = {
{to: '/pro', label: 'React on Rails Pro', position: 'left'},
{
href: 'https://www.shakacode.com/contact/',
label: 'Get Expert Help',
label: 'Get expert help',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Please confirm prior approval for config-file edits.

This file has a repo-specific guardrail requiring “ask first” before any change to prototypes/docusaurus/docusaurus.config.ts. I don’t see evidence of that approval in the provided context; please add explicit confirmation in the PR discussion/description before merge.

As per coding guidelines: “Ask first before making changes to Docusaurus configuration (prototypes/docusaurus/docusaurus.config.ts).”

Also applies to: 194-194

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@prototypes/docusaurus/docusaurus.config.ts` at line 137, Before merging, add
an explicit confirmation in the PR description/discussion that you received
prior approval to edit the Docusaurus configuration (specifically the change
touching the config entry with label: 'Get expert help') and note who approved
it; update the PR body to state the approver's name and timestamp so reviewers
can verify the required "ask first" guardrail has been followed.

position: 'right',
className: 'navbar-cta',
},
Expand Down Expand Up @@ -191,7 +191,7 @@ const config: Config = {
href: 'https://www.shakacode.com',
},
{
Comment thread
cursor[bot] marked this conversation as resolved.
label: 'Book a Complimentary Assessment',
label: 'Book a complimentary assessment',
href: 'https://meetings.hubspot.com/justingordon/30-minute-consultation',
},
],
Expand Down
2 changes: 1 addition & 1 deletion prototypes/docusaurus/src/css/custom.css
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ body {
text-decoration: underline;
}

/* "Get Expert Help" navbar CTA */
/* "Get expert help" navbar CTA */
.navbar-cta {
background: var(--ifm-color-primary);
color: #ffffff !important;
Expand Down
4 changes: 2 additions & 2 deletions prototypes/docusaurus/src/pages/pro.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ const proFeatures = [

const demos = [
{
title: 'LocalHub — RSC performance demo',
title: 'Marketplace — RSC performance demo',
description:
'A marketplace built on Pro + RSC, with Lighthouse reports and bundle-size evidence you can inspect.',
liveHref: 'https://rsc.reactonrails.com/search-performance',
liveHref: 'https://rsc.reactonrails.com',
sourceHref: 'https://github.com/shakacode/react-on-rails-demo-marketplace-rsc',
},
{
Expand Down
Loading