Commit 6cf99b7
fix: export ThreadPool symbols and silence google-runtime-int lint
Two CI failures from the previous push:
1. Meson lanes (Linux/macOS/Windows) failed to link `util_test` against
`libiceberg.so` with undefined references to `iceberg::ThreadPool::*`. The
project sets CXX_VISIBILITY_PRESET=hidden, so symbols crossing the shared-
library boundary need ICEBERG_EXPORT. CMake builds use static archives
locally, which is why this only surfaced on the Meson shared-lib lanes.
Adding ICEBERG_EXPORT to the class follows the same pattern as
RetryRunner/ExpireSnapshots: the `_internal.h` naming is a header-org hint,
not a visibility decision.
2. cpp-linter (clang-tidy google-runtime-int) flagged `std::atomic<long>` in
thread_pool_test.cc. Switched to `std::atomic<std::int64_t>`.
The zizmor failure on the same run was a docker-pull timeout pulling
`ghcr.io/zizmorcore/zizmor:latest` — pure infra flake, no source change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 6b6f323 commit 6cf99b7
2 files changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
50 | | - | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
43 | | - | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
0 commit comments