fix(agent): keep legacy agent files read-only

Author: im10furry

apps/cli/src/commands/agent/agents/storage.test.ts

@@ -0,0 +1,91 @@
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test'
+import {
+  existsSync,
+  mkdirSync,
+  mkdtempSync,
+  readFileSync,
+  rmSync,
+  writeFileSync,
+} from 'fs'
+import { join } from 'path'
+import { tmpdir } from 'os'
+
+import type { AgentConfig } from '#core/utils/agentLoader'
+import { getCwd, setCwd } from '#core/utils/state'
+
+import { deleteAgent, updateAgent } from './storage'
+
+describe('agents/storage Kode-first writes', () => {
+  let originalCwd: string
+  let projectDir: string
+
+  beforeEach(async () => {
+    originalCwd = getCwd()
+    projectDir = mkdtempSync(join(tmpdir(), 'kode-agent-storage-'))
+    await setCwd(projectDir)
+  })
+
+  afterEach(async () => {
+    await setCwd(originalCwd)
+    rmSync(projectDir, { recursive: true, force: true })
+  })
+
+  function projectAgent(agentType: string): AgentConfig {
+    return {
+      agentType,
+      whenToUse: 'Use this agent when testing storage behavior.',
+      tools: '*',
+      systemPrompt: 'You are a storage behavior test agent.',
+      source: 'projectSettings',
+      location: 'project',
+    }
+  }
+
+  test('updateAgent writes a primary .kode override instead of modifying legacy .claude', async () => {
+    const legacyDir = join(projectDir, '.claude', 'agents')
+    const legacyPath = join(legacyDir, 'legacy-agent.md')
+    const primaryPath = join(projectDir, '.kode', 'agents', 'legacy-agent.md')
+    mkdirSync(legacyDir, { recursive: true })
+    writeFileSync(
+      legacyPath,
+      '---\nname: legacy-agent\ndescription: "legacy"\n---\n\nLegacy prompt\n',
+    )
+
+    await updateAgent(
+      projectAgent('legacy-agent'),
+      'Use this agent when editing legacy agents.',
+      ['Read'],
+      'You are an updated primary agent prompt.',
+    )
+
+    expect(existsSync(primaryPath)).toBe(true)
+    expect(readFileSync(primaryPath, 'utf8')).toContain('\ntools: Read')
+    expect(readFileSync(legacyPath, 'utf8')).toContain('Legacy prompt')
+  })
+
+  test('deleteAgent removes only primary files and rejects legacy-only deletes', async () => {
+    const primaryDir = join(projectDir, '.kode', 'agents')
+    const legacyDir = join(projectDir, '.claude', 'agents')
+    const primaryPath = join(primaryDir, 'demo-agent.md')
+    const legacyPath = join(legacyDir, 'demo-agent.md')
+    mkdirSync(primaryDir, { recursive: true })
+    mkdirSync(legacyDir, { recursive: true })
+    writeFileSync(
+      primaryPath,
+      '---\nname: demo-agent\ndescription: "primary"\n---\n\nPrimary prompt\n',
+    )
+    writeFileSync(
+      legacyPath,
+      '---\nname: demo-agent\ndescription: "legacy"\n---\n\nLegacy prompt\n',
+    )
+
+    await deleteAgent(projectAgent('demo-agent'))
+    expect(existsSync(primaryPath)).toBe(false)
+    expect(existsSync(legacyPath)).toBe(true)
+
+    await expect(deleteAgent(projectAgent('demo-agent'))).rejects.toThrow(
+      'Cannot delete legacy agent "demo-agent" from .claude',
+    )
+    expect(existsSync(legacyPath)).toBe(true)
+  })
+})

apps/cli/src/commands/agent/agents/storage.ts

@@ -160,15 +160,9 @@ export async function updateAgent(
 
   const location = agent.location as AgentLocation
   const primaryPath = getPrimaryAgentFilePath(location, agent.agentType)
-  const legacyPath = getLegacyAgentFilePath(location, agent.agentType)
-  const filePath = existsSync(primaryPath)
-    ? primaryPath
-    : existsSync(legacyPath)
-      ? legacyPath
-      : primaryPath
 
   ensureDirectoryExists(location)
-  writeFileSync(filePath, content, { encoding: 'utf-8', flag: 'w' })
+  writeFileSync(primaryPath, content, { encoding: 'utf-8', flag: 'w' })
 }
 
 export async function deleteAgent(agent: AgentConfig): Promise<void> {
@@ -182,8 +176,12 @@ export async function deleteAgent(agent: AgentConfig): Promise<void> {
 
   if (existsSync(primaryPath)) {
     unlinkSync(primaryPath)
+    return
   }
+
   if (existsSync(legacyPath)) {
-    unlinkSync(legacyPath)
+    throw new Error(
+      `Cannot delete legacy agent "${agent.agentType}" from .claude. Legacy agents are read-only; remove it manually or create a .kode override.`,
+    )
   }
 }