Skip to content

Commit 950378a

Browse files
committed
fix: remove hardcoded assistant acks after system message injection
s08/s09/s10/s11/s_full inject background-results and inbox as user messages before LLM calls. The paired hardcoded assistant "Noted..." responses were unnecessary — consecutive user messages work fine and the fake acks added noise with no functional value. Affected: agents/s08, s09, s10, s11, s_full + docs (zh/en/ja s08, s09)
1 parent 1ffdf3d commit 950378a

11 files changed

Lines changed: 0 additions & 27 deletions

agents/s08_background_tasks.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ def agent_loop(messages: list):
194194
f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs
195195
)
196196
messages.append({"role": "user", "content": f"<background-results>\n{notif_text}\n</background-results>"})
197-
messages.append({"role": "assistant", "content": "Noted background results."})
198197
response = client.messages.create(
199198
model=MODEL, system=SYSTEM, messages=messages,
200199
tools=TOOLS, max_tokens=8000,

agents/s09_agent_teams.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -350,10 +350,6 @@ def agent_loop(messages: list):
350350
"role": "user",
351351
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
352352
})
353-
messages.append({
354-
"role": "assistant",
355-
"content": "Noted inbox messages.",
356-
})
357353
response = client.messages.create(
358354
model=MODEL,
359355
system=SYSTEM,

agents/s10_team_protocols.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -431,10 +431,6 @@ def agent_loop(messages: list):
431431
"role": "user",
432432
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
433433
})
434-
messages.append({
435-
"role": "assistant",
436-
"content": "Noted inbox messages.",
437-
})
438434
response = client.messages.create(
439435
model=MODEL,
440436
system=SYSTEM,

agents/s11_autonomous_agents.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -515,10 +515,6 @@ def agent_loop(messages: list):
515515
"role": "user",
516516
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
517517
})
518-
messages.append({
519-
"role": "assistant",
520-
"content": "Noted inbox messages.",
521-
})
522518
response = client.messages.create(
523519
model=MODEL,
524520
system=SYSTEM,

agents/s_full.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -664,12 +664,10 @@ def agent_loop(messages: list):
664664
if notifs:
665665
txt = "\n".join(f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs)
666666
messages.append({"role": "user", "content": f"<background-results>\n{txt}\n</background-results>"})
667-
messages.append({"role": "assistant", "content": "Noted background results."})
668667
# s10: check lead inbox
669668
inbox = BUS.read_inbox("lead")
670669
if inbox:
671670
messages.append({"role": "user", "content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>"})
672-
messages.append({"role": "assistant", "content": "Noted inbox messages."})
673671
# LLM call
674672
response = client.messages.create(
675673
model=MODEL, system=SYSTEM, messages=messages,

docs/en/s08-background-tasks.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ def agent_loop(messages: list):
8181
messages.append({"role": "user",
8282
"content": f"<background-results>\n{notif_text}\n"
8383
f"</background-results>"})
84-
messages.append({"role": "assistant",
85-
"content": "Noted background results."})
8684
response = client.messages.create(...)
8785
```
8886

docs/en/s09-agent-teams.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt):
9393
if inbox != "[]":
9494
messages.append({"role": "user",
9595
"content": f"<inbox>{inbox}</inbox>"})
96-
messages.append({"role": "assistant",
97-
"content": "Noted inbox messages."})
9896
response = client.messages.create(...)
9997
if response.stop_reason != "tool_use":
10098
break

docs/ja/s08-background-tasks.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ def agent_loop(messages: list):
8181
messages.append({"role": "user",
8282
"content": f"<background-results>\n{notif_text}\n"
8383
f"</background-results>"})
84-
messages.append({"role": "assistant",
85-
"content": "Noted background results."})
8684
response = client.messages.create(...)
8785
```
8886

docs/ja/s09-agent-teams.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt):
9393
if inbox != "[]":
9494
messages.append({"role": "user",
9595
"content": f"<inbox>{inbox}</inbox>"})
96-
messages.append({"role": "assistant",
97-
"content": "Noted inbox messages."})
9896
response = client.messages.create(...)
9997
if response.stop_reason != "tool_use":
10098
break

docs/zh/s08-background-tasks.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ def agent_loop(messages: list):
8181
messages.append({"role": "user",
8282
"content": f"<background-results>\n{notif_text}\n"
8383
f"</background-results>"})
84-
messages.append({"role": "assistant",
85-
"content": "Noted background results."})
8684
response = client.messages.create(...)
8785
```
8886

0 commit comments

Comments
 (0)