Add extension placeholder#2012
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
{.ext}formatter token that expands to the current path's file extension--format,--exec, and--exec-batchplaceholder parsingI used a single
{.ext}placeholder because Rust'sPath::extension()is based on the final path component, so{.ext}and{/.ext}would return the same value.AI assistance: an AI coding assistant helped draft the patch and tests. I reviewed the change and ran the verification below.
Refs #1818
Tests:
CARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo test fmt::fmt_tests::extension_placeholder -- --nocaptureCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo test exec::tests::tokens_with_extension -- --nocaptureCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo test fmt::input::path_tests::extension_simple -- --nocaptureCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo test --test tests format -- --nocaptureCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo test --test tests test_exec -- --nocaptureCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo fmt -- --checkCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo testCARGO_HOME=/tmp/fd-1818-cargo-home CARGO_TARGET_DIR=/tmp/fd-1818-target cargo clippy --all-targets -- -D warningsgit diff --check