fix: show faster/slower annotations with --sort command and --reference#879
Open
leno23 wants to merge 1 commit into
Open
fix: show faster/slower annotations with --sort command and --reference#879leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When --sort command is used with an explicit --reference, the relative speed table now includes "times faster/slower than <reference>" labels, matching the Summary output for --sort mean-time. Fixes sharkdp#811 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--sort commandis used together with--reference, the relative speed table previously showed only numeric ratios without the "times faster/slower than …" labels that appear in the default Summary output.This adds those annotations to the command-sorted table when an explicit
--referenceis set (reference row stays at1.00without a suffix).Fixes #811
Test plan
cargo test shows_faster_slower_annotations_with_sort_command_and_referencecargo fmtMade with Cursor