feat: add --ignore-exit-code alias for --ignore-failure (fixes #828)#886
Open
leno23 wants to merge 1 commit into
Open
feat: add --ignore-exit-code alias for --ignore-failure (fixes #828)#886leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…p#828) The new name better reflects that the flag ignores non-zero exit codes rather than discarding failed benchmark measurements. The old flag is kept for compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #828.
Adds
--ignore-exit-codeas an alias for the existing--ignore-failureflag (and-ishort option). The new name better reflects what the flag does: ignore non-zero exit codes rather than ignoring failed benchmark measurements (as discussed in #827).The old
--ignore-failurename is retained for backward compatibility.Changes
--ignore-exit-codeas a clap alias on the existingignore-failureargumentdoc/hyperfine.1--ignore-exit-codeand--ignore-exit-code=1Test plan
cargo test ignore_exit_codecargo clippy -- -D warningsMade with Cursor