Skip to content

Commit 76fb1b6

Browse files
authored
refactor(api): remove redundant typing.cast calls (langgenius#37124)
1 parent 157ba6f commit 76fb1b6

6 files changed

Lines changed: 11 additions & 11 deletions

File tree

api/core/workflow/generator/runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ def _invoke_and_parse_json(
434434
if isinstance(parsed, dict):
435435
if attempt > 0:
436436
logger.info("Workflow generator: %s JSON parse recovered on retry", stage)
437-
return cast(dict[str, Any], parsed)
437+
return parsed
438438
last_detail = f"Non-object JSON: {type(parsed).__name__}"
439439
logger.info("Workflow generator: %s non-object JSON on attempt %s", stage, attempt + 1)
440440
raise _StageJSONError(stage, last_detail or "JSON parse failed")

api/core/workflow/nodes/agent_v2/plugin_tools_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import annotations
22

33
from collections.abc import Mapping
4-
from typing import Any, Protocol, cast
4+
from typing import Any, Protocol
55

66
from dify_agent.layers.dify_plugin import (
77
DifyPluginCredentialValue,
@@ -197,7 +197,7 @@ def _to_backend_tool_config(
197197
credentials=self._normalize_credentials(runtime.credentials, tool_name=tool_config.tool_name),
198198
runtime_parameters=runtime_parameters,
199199
parameters=parameters,
200-
parameters_json_schema=cast(dict[str, Any], tool_runtime.get_llm_parameters_json_schema()),
200+
parameters_json_schema=tool_runtime.get_llm_parameters_json_schema(),
201201
)
202202

203203
@staticmethod

api/enterprise/telemetry/enterprise_trace.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ def _dataset_retrieval_trace(self, info: DatasetRetrievalTraceInfo) -> None:
720720

721721
docs: list[dict[str, Any]] = []
722722
documents_any: Any = info.documents
723-
documents_list: list[Any] = cast(list[Any], documents_any) if isinstance(documents_any, list) else []
723+
documents_list: list[Any] = documents_any if isinstance(documents_any, list) else []
724724
for entry in documents_list:
725725
if isinstance(entry, dict):
726726
entry_dict: dict[str, Any] = cast(dict[str, Any], entry)

api/models/dataset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1226,7 +1226,7 @@ def object_hook(dct: Any) -> Any:
12261226
items = cast(dict[str, Any], dct).items()
12271227
for keyword, node_idxs in items:
12281228
if isinstance(node_idxs, list):
1229-
result[keyword] = set(cast(list[Any], node_idxs))
1229+
result[keyword] = set(node_idxs)
12301230
else:
12311231
result[keyword] = node_idxs
12321232
return result

api/models/model.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,7 @@ def inputs(self) -> dict[str, Any]:
11531153
tenant_resolver=tenant_resolver,
11541154
)
11551155
elif isinstance(value, list):
1156-
value_list = cast(list[Any], value)
1156+
value_list = value
11571157
if all(
11581158
isinstance(item, dict)
11591159
and cast(dict[str, Any], item).get("dify_model_identity") == FILE_MODEL_IDENTITY
@@ -1181,7 +1181,7 @@ def inputs(self, value: Mapping[str, Any]):
11811181
if isinstance(v, File):
11821182
inputs[k] = v.model_dump()
11831183
elif isinstance(v, list):
1184-
v_list = cast(list[Any], v)
1184+
v_list = v
11851185
if all(isinstance(item, File) for item in v_list):
11861186
inputs[k] = [item.model_dump() for item in v_list if isinstance(item, File)]
11871187
self._inputs = inputs
@@ -1495,7 +1495,7 @@ def inputs(self) -> dict[str, Any]:
14951495
tenant_resolver=tenant_resolver,
14961496
)
14971497
elif isinstance(value, list):
1498-
value_list = cast(list[Any], value)
1498+
value_list = value
14991499
if all(
15001500
isinstance(item, dict)
15011501
and cast(dict[str, Any], item).get("dify_model_identity") == FILE_MODEL_IDENTITY
@@ -1522,7 +1522,7 @@ def inputs(self, value: Mapping[str, Any]):
15221522
if isinstance(v, File):
15231523
inputs[k] = v.model_dump()
15241524
elif isinstance(v, list):
1525-
v_list = cast(list[Any], v)
1525+
v_list = v
15261526
if all(isinstance(item, File) for item in v_list):
15271527
inputs[k] = [item.model_dump() for item in v_list if isinstance(item, File)]
15281528
self._inputs = inputs

api/models/workflow.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1688,7 +1688,7 @@ def _rebuild_file_types(self, value: Any):
16881688
tenant_id=tenant_id,
16891689
)
16901690
case list() if value:
1691-
value_list = cast(list[Any], value)
1691+
value_list = value
16921692
first: Any = value_list[0]
16931693
if not maybe_file_object(first):
16941694
return cast(Any, value)
@@ -1742,7 +1742,7 @@ def rebuild_file_types(value: Any):
17421742
normalized_file.pop("tenant_id", None)
17431743
return build_file_from_mapping_without_lookup(file_mapping=normalized_file)
17441744
case list() if value:
1745-
value_list = cast(list[Any], value)
1745+
value_list = value
17461746
first: Any = value_list[0]
17471747
if not maybe_file_object(first):
17481748
return cast(Any, value)

0 commit comments

Comments
 (0)