Skip to content

Commit 92f5808

Browse files
committed
Ensure validation happens in deterministic order.
1 parent 4870eba commit 92f5808

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

DependencyQueue/DependencyQueue.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,11 @@ private IReadOnlyList<DependencyQueueError> ValidateCore()
554554
var errors = new List<DependencyQueueError>();
555555
var visited = new Dictionary<string, bool>(_topics.Count, _comparer);
556556

557-
foreach (var topic in _topics.Values)
557+
// Ensure topics are visited in a deterministic order
558+
var topics = _topics.Values.ToArray();
559+
Array.Sort(topics, (a, b) => _comparer.Compare(a.Name, b.Name));
560+
561+
foreach (var topic in topics)
558562
{
559563
if (topic.ProvidedBy.Count == 0)
560564
errors.Add(DependencyQueueError.UnprovidedTopic(topic));

0 commit comments

Comments
 (0)