le clobbered code

rtldg · web-flow · commit 8414ebffa419 · 2026-04-27T12:31:15.000Z
diff --git a/addons/sourcemod/scripting/shavit-replay-recorder.sp b/addons/sourcemod/scripting/shavit-replay-recorder.sp
@@ -494,11 +494,13 @@ void FloppyAsynchronouslySavedMyReplayWhichWasNiceOfThem(bool saved, any value)
 	int postframes = dp.ReadCell();
 	char sName[MAX_NAME_LENGTH];
 	dp.ReadString(sName, sizeof(sName));
+	delete dp;
 
 	if (!saved)
 	{
 		LogError("Failed to save replay... Skipping OnReplaySaved");
 		delete playerrecording; // importante!
+		delete paths;
 		return;
 	}
 
@@ -525,6 +527,7 @@ void FloppyAsynchronouslySavedMyReplayWhichWasNiceOfThem(bool saved, any value)
 	Call_Finish();
 
 	delete playerrecording;
+	delete paths;
 }
 
 public void Shavit_OnFinish(int client, int style, float time, int jumps, int strafes, float sync, int track, float oldtime, float perfs, float avgvel, float maxvel, int timestamp)

Original file line number	Diff line number	Diff line change
`@@ -494,11 +494,13 @@ void FloppyAsynchronouslySavedMyReplayWhichWasNiceOfThem(bool saved, any value)`
`494`	`494`	`int postframes = dp.ReadCell();`
`495`	`495`	`char sName[MAX_NAME_LENGTH];`
`496`	`496`	`dp.ReadString(sName, sizeof(sName));`
	`497`	`+ delete dp;`
`497`	`498`
`498`	`499`	`if (!saved)`
`499`	`500`	`{`
`500`	`501`	`LogError("Failed to save replay... Skipping OnReplaySaved");`
`501`	`502`	`delete playerrecording; // importante!`
	`503`	`+ delete paths;`
`502`	`504`	`return;`
`503`	`505`	`}`
`504`	`506`
`@@ -525,6 +527,7 @@ void FloppyAsynchronouslySavedMyReplayWhichWasNiceOfThem(bool saved, any value)`
`525`	`527`	`Call_Finish();`
`526`	`528`
`527`	`529`	`delete playerrecording;`
	`530`	`+ delete paths;`
`528`	`531`	`}`
`529`	`532`
`530`	`533`	`public void Shavit_OnFinish(int client, int style, float time, int jumps, int strafes, float sync, int track, float oldtime, float perfs, float avgvel, float maxvel, int timestamp)`