Fetch results from jobs#26
Closed
Thynkon wants to merge 1 commit into
Closed
Conversation
Now, on_success/1 becomes on_success/2 which receives boths job and the result. Also, on_failure/2 now receives the job instead of the job's arguments. In some cases, we might want to launch a background job that will fetch some data. Thus, the result of the job must be available. Instead of simply launch a new worker with Supervisor.start_child/2, Task.Supervisor.async_nolink/3 is then called. Once the job finishes, the parent is then called.
Owner
|
Closing for now. While the proposed changes look interesting and I appreciate your contribution, I would first prefer a deeper discussion regarding them before they're added to the codebase. The goal is to introduce new features only when we've thought through them and have a non-breaking implementation plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, we might want to launch a background job that will fetch some data. Thus, the result of the job must be available.
Now, on_success/1 becomes on_success/2 which receives both job and the result. Also, on_failure/2 now receives the job instead of the job's arguments.
Instead of simply launch a new worker with Supervisor.start_child/2, Task.Supervisor.async_nolink/3 is then called. Once the job finishes, the parent is then called.
This PR introduces breaking changes as
Que.Worker.on_success/1becomesQue.Worker.on_success/2andQue.Worker.on_failure/2now receives the job instead of the job's arguments.