Suppress Valgrind false positive and enable 2D array support#70
Merged
shekohex merged 2 commits intoSep 2, 2025
Merged
Conversation
Co-authored-by: shekohex <14620076+shekohex@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Hey could you suppress the above error https://github.com/shekohex/allo-isolate/pull/66#issuecomment-2887855705 and from the CI https://github.com/shekohex/allo-isolate/actions/runs/15070928728/job/42366794103?pr=66 Look into the PR #66 and the full c...
Suppress Valgrind false positive and enable 2D array support
Sep 1, 2025
shekohex
marked this pull request as ready for review
September 1, 2025 18:34
shekohex
approved these changes
Sep 1, 2025
Owner
|
Original Code by @fzyzcjy btw. |
shekohex
deleted the
copilot/fix-dea96db4-9656-499e-b5fd-5e9ec97ed096
branch
September 2, 2025 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the Valgrind memory leak false positive that was blocking PR #66 and includes the 2D array functionality from that PR.
Problem
PR #66 introduced support for 2D arrays like
[[A; N]; M]but caused the CI to fail due to a Valgrind memory leak detection. Investigation showed this was a false positive related to Rust's random number generator initialization:The stack trace shows this originates from
fastrand::global_rng::RNGinitialization, which is a known false positive in Rust applications.Solution
valgrind.supp) to suppress the false positive memory leak from Rust's allocator initialization--suppressions=valgrind.suppin the Valgrind commandIntoDartExceptPrimitivefor[T; N]arrays (from PR Fix[[A; N]; M]cannot be used with allo isolate #66)Testing
The fix was verified by:
Example Usage
With these changes, 2D arrays now work correctly:
Fixes the issue described in fzyzcjy/flutter_rust_bridge#2703
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.