Add extensive console.log in PTY manager and lifecycle to debug CI failures

Author: MBanucu

src/plugin/pty/OutputManager.ts

@@ -2,10 +2,18 @@ import type { PTYSession, ReadResult, SearchResult } from './types.ts'
 
 export class OutputManager {
   write(session: PTYSession, data: string): boolean {
+    console.log(
+      'OutputManager write for session:',
+      session.id,
+      'process exists:',
+      !!session.process
+    )
     try {
       session.process!.write(data)
+      console.log('OutputManager write succeeded')
       return true
     } catch (err) {
+      console.log('OutputManager write failed:', err)
       return true // allow write to exited process for tests
     }
   }

src/plugin/pty/SessionLifecycle.ts

@@ -42,29 +42,39 @@ export class SessionLifecycleManager {
   }
 
   private spawnProcess(session: PTYSession): void {
+    console.log('Spawning PTY process for command:', session.command, 'args:', session.args)
     const env = { ...process.env, ...session.env } as Record<string, string>
-    const ptyProcess: IPty = spawn(session.command, session.args, {
-      name: 'xterm-256color',
-      cols: DEFAULT_TERMINAL_COLS,
-      rows: DEFAULT_TERMINAL_ROWS,
-      cwd: session.workdir,
-      env,
-    })
-    session.process = ptyProcess
-    session.pid = ptyProcess.pid
+    try {
+      const ptyProcess: IPty = spawn(session.command, session.args, {
+        name: 'xterm-256color',
+        cols: DEFAULT_TERMINAL_COLS,
+        rows: DEFAULT_TERMINAL_ROWS,
+        cwd: session.workdir,
+        env,
+      })
+      console.log('PTY process spawned with pid:', ptyProcess.pid)
+      session.process = ptyProcess
+      session.pid = ptyProcess.pid
+    } catch (error) {
+      console.error('Failed to spawn PTY process:', error)
+      throw error
+    }
   }
 
   private setupEventHandlers(
     session: PTYSession,
     onData: (id: string, data: string) => void,
     onExit: (id: string, exitCode: number | null) => void
   ): void {
+    console.log('Setting up event handlers for session:', session.id)
     session.process!.onData((data: string) => {
+      console.log('PTY onData for session', session.id, 'data length:', data.length)
       session.buffer.append(data)
       onData(session.id, data)
     })
 
     session.process!.onExit(({ exitCode }) => {
+      console.log('PTY onExit for session', session.id, 'exitCode:', exitCode)
       // Flush any remaining incomplete line in the buffer
       session.buffer.flush()
 
@@ -134,7 +144,16 @@ export class SessionLifecycleManager {
   }
 
   getSession(id: string): PTYSession | null {
-    return this.sessions.get(id) || null
+    const session = this.sessions.get(id) || null
+    console.log('SessionLifecycle getSession for id:', id, 'found:', !!session)
+    if (session)
+      console.log('Session details:', {
+        id: session.id,
+        pid: session.pid,
+        status: session.status,
+        process: !!session.process,
+      })
+    return session
   }
 
   listSessions(): PTYSession[] {

src/plugin/pty/manager.ts

@@ -41,30 +41,37 @@ class PTYManager {
   }
 
   spawn(opts: SpawnOptions): PTYSessionInfo {
+    console.log('Manager spawn called with opts:', opts)
     const session = this.lifecycleManager.spawn(
       opts,
       (id, data) => {
+        console.log('Manager onData callback for id:', id, 'data length:', data.length)
         notifyRawOutput(id, data)
       },
       async (id, exitCode) => {
+        console.log('Manager onExit callback for id:', id, 'exitCode:', exitCode)
         if (onSessionUpdate) onSessionUpdate()
         const session = this.lifecycleManager.getSession(id)
         if (session && session.notifyOnExit) {
           await this.notificationManager.sendExitNotification(session, exitCode || 0)
         }
       }
     )
+    console.log('Manager spawn returning session:', session)
     if (onSessionUpdate) onSessionUpdate()
     return session
   }
 
   write(id: string, data: string): boolean {
-    return withSession(
+    console.log('Manager write called for id:', id, 'data:', data)
+    const result = withSession(
       this.lifecycleManager,
       id,
       (session) => this.outputManager.write(session, data),
       false
     )
+    console.log('Manager write result:', result)
+    return result
   }
 
   read(id: string, offset: number = 0, limit?: number): ReadResult | null {