fix: update web server binding to IPv6 localhost

Change default hostname from 'localhost' to '::1' for IPv6 support.
Add PTY_WEB_HOSTNAME environment variable to allow configuration.
Update tests and documentation accordingly.

Author: MBanucu

README.md

@@ -222,9 +222,10 @@ This eliminates the need for polling—perfect for long-running processes like b
 
 ### Environment Variables
 
-| Variable               | Default | Description                                        |
-| ---------------------- | ------- | -------------------------------------------------- |
-| `PTY_MAX_BUFFER_LINES` | `50000` | Maximum lines to keep in output buffer per session |
+| Variable               | Default    | Description                                        |
+| ---------------------- | ---------- | -------------------------------------------------- |
+| `PTY_MAX_BUFFER_LINES` | `50000`    | Maximum lines to keep in output buffer per session |
+| `PTY_WEB_HOSTNAME`     | `::1`      | Hostname for the web server to bind to             |
 
 ### Permissions
 

src/web/server/server.ts

@@ -1,23 +1,21 @@
 import type { Server } from 'bun'
+import { routes } from '../shared/routes.ts'
+import { CallbackManager } from './callback-manager.ts'
 import { handleHealth } from './handlers/health.ts'
 import {
-  getSessions,
-  createSession,
+  cleanupSession,
   clearSessions,
+  createSession,
+  getPlainBuffer,
+  getRawBuffer,
   getSession,
-  sendInput,
+  getSessions,
   killSession,
-  getRawBuffer,
-  getPlainBuffer,
-  cleanupSession,
+  sendInput,
 } from './handlers/sessions.ts'
-
 import { buildStaticRoutes } from './handlers/static.ts'
 import { handleUpgrade } from './handlers/upgrade.ts'
 import { handleWebSocketMessage } from './handlers/websocket.ts'
-import { CallbackManager } from './callback-manager.ts'
-
-import { routes } from '../shared/routes.ts'
 
 export class PTYServer implements Disposable {
   public readonly server: Server<undefined>
@@ -44,6 +42,7 @@ export class PTYServer implements Disposable {
   private startWebServer(): Server<undefined> {
     return Bun.serve({
       port: 0,
+      hostname: process.env.PTY_WEB_HOSTNAME ?? '::1',
 
       routes: {
         ...this.staticRoutes,

test/e2e/fixtures.ts

@@ -1,5 +1,5 @@
+import { type ChildProcess, spawn } from 'node:child_process'
 import { test as base, type WorkerInfo } from '@playwright/test'
-import { spawn, type ChildProcess } from 'node:child_process'
 
 import { createApiClient } from '../../src/web/shared/api-client.ts'
 import { ManagedTestClient } from '../utils'
@@ -90,12 +90,12 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({
         const serverURL = serverURLText.trim()
 
         // Parse URL to extract port number
-        const urlMatch = serverURL.match(/http:\/\/localhost:(\d+)/)
+        const urlMatch = serverURL.match(/http:\/\/\[::1\]:(\d+)/)
         if (!urlMatch || !urlMatch[1]) {
           throw new Error(`Invalid port file format: ${serverURL}`)
         }
         const port = parseInt(urlMatch[1], 10)
-        const baseURL = `http://localhost:${port}`
+        const baseURL = `http://[::1]:${port}`
 
         await waitForServer(baseURL, 15000)
 

test/web-server.test.ts

@@ -1,19 +1,19 @@
-import { describe, it, expect, afterAll, beforeAll } from 'bun:test'
+import { afterAll, beforeAll, describe, expect, it } from 'bun:test'
 import {
   manager,
   registerRawOutputCallback,
   registerSessionUpdateCallback,
 } from '../src/plugin/pty/manager.ts'
-import { PTYServer } from '../src/web/server/server.ts'
 import type { PTYSessionInfo } from '../src/plugin/pty/types.ts'
+import { PTYServer } from '../src/web/server/server.ts'
 import { ManagedTestServer } from './utils.ts'
 
 describe('Web Server', () => {
   describe('Server Lifecycle', () => {
     it('should start server successfully', async () => {
       await using server = await PTYServer.createServer()
       const url = server.server.url
-      expect(url.hostname).toBe('localhost')
+      expect(url.hostname).toBe('[::1]')
       expect(url.protocol).toBe('http:')
       expect(url.port).not.toBe(0)
       expect(url.port).not.toBe(8080) // Default port should be avoided