Commit 56952cc
authored
ci: switch to Biome (#20)
* build: switch to Biome from ESLint and Prettier
* style: change font-family quotes from single to double in index.css
* style: apply Biome formatting and linting rules
- Remove explicit undefined assignments in variable declarations
- Use class name instead of 'this' in static methods
- Convert value imports to type imports where appropriate
- Use 'const' instead of 'let' for variables not reassigned
* refactor: add explicit type to error boundary reset button
* fix: add type="button" to button elements in web components
Prevent implicit form submission by explicitly setting button type.
* feat: add keyboard accessibility to sidebar session items
Add role='button', tabIndex, and onKeyDown handler to session items
in the sidebar to enable keyboard navigation with Enter and Space keys.
This improves accessibility for users relying on keyboard input.
* refactor: replace div with button in sidebar for semantic HTML
Use proper semantic HTML elements for better accessibility instead of div with role attribute.
* chore: update opencode command definitions and rename directory
- Rename .opencode/commands/ to .opencode/command/
- Update changelog-update.md to curate [Unreleased] section only
- Enhance commit.md with detailed conventional commits guidelines
* style: add explicit type attribute to button elements
- Add type="button" to session navigation buttons in sidebar component
- Ensures buttons do not accidentally submit forms if context changes
- Improves code clarity and satisfies linting requirements
* style: format test/utils.ts with biome
* style: add curly braces to forEach callback
* style: format arrow function braces in test utils
* style(test/utils): add braces to arrow functions in forEach
Biome requires braces for arrow functions in forEach callbacks to improve code consistency and readability.
* refactor: simplify CustomError class by removing redundant constructor
* fix: correct Symbol.dispose syntax in web server test
Symbol.dispose should not have quotes around 'dispose'.
* chore: remove incomplete DOM vs serialize addon comparison test
* fix: add null check for root element in client
Prevent runtime error by throwing a clear error message if the root DOM element is not found.
* refactor(web/client): remove performance monitoring
Remove unused performance monitoring utilities and initialization
from the web client, including the PerformanceMonitor class and
web vitals tracking functionality.
* ci: update test fixtures for Biome linting
* refactor: change RouteBuilder from class to object
* fix(test): prevent runtime error in e2e fixtures port parsing
Ensure urlMatch[1] exists before parsing to avoid parseInt(undefined).
This fixes a potential bug where the regex might not capture the port group.
* ci: switch to Biome
Apply Biome linting and formatting rules to the codebase, including:
- Modern Node.js imports (node:path, etc.)
- Template literals for string concatenation
- Optional chaining for safer property access
- Explicit radix for parseInt
- Removal of non-null assertions where safe
* style: remove unnecessary non-null assertion from WebSocket constructor
* build: update lint ignore to biome in xterm-test-helpers.ts
Switch the lint ignore directive from ESLint to Biome syntax for the control characters regex in the stripAnsi function.
* style: format code with biome
* ci: replace combined quality job with separate biome checks
- Split the 'quality' matrix job into individual jobs for test, typecheck, lint, format:check, and test:e2e
- This allows parallel execution and clearer failure identification for each check
* chore: switch development environment from nix flake to devenv
Replace flake.nix with devenv.nix and devenv.yaml for improved dev env management.
Update .envrc to use devenv instead of flake.
Adjust .gitignore to ignore devenv and direnv files.
Update biome to version 2.3.13 and adjust package.json scripts.
* Add flake symlinks for devenv
* revert: Add flake symlinks for devenv
* ci: switch CI to use devenv with biome
- Update CI workflow to use devenv shell instead of nix develop
- Add biome and bashInteractive packages to devenv.nix
- Change nixpkgs input in devenv.yaml to nixos-unstable
- Update devenv.lock accordingly
* ci: add step to install devenv in CI workflow
Install devenv using nix profile install nixpkgs#devenv to enable
running bun commands within devenv shell environment.
* ci: update workflow quality checks to run format instead of format:check
Switch from format:check to format in the CI matrix to align with
the transition to biome for code formatting.
* ci: switch nix-flake-test job from matrix to sequential steps
Remove the strategy matrix from the nix-flake-test job and replace it with
individual steps for each quality check (test, typecheck, lint, format,
test:e2e). This changes the execution from parallel matrix jobs to
sequential steps in a single job.
* build: add bun to devenv packages
* ci: update Bun version and fix nix profile command
- Bump Bun version from 1.3.6 to 1.3.8
- Change nix profile install to add for devenv
* build: configure Biome for linting and formatting
- Enable JavaScript language support in devenv
- Add Bun 1.3.8 via bun.enable
- Remove direct bun package from packages
- Add format and format:fix scripts using Biome
- Remove node_modules/.bin from PATH in enterShell
* build(devenv): add playwright browser support
Add let block to dynamically determine chromium and firefox revisions from playwright-driver.browsers.json.
Include playwright-driver.browsers in packages and set PLAYWRIGHT_BROWSERS_PATH, PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH, and PLAYWRIGHT_FIREFOX_EXECUTABLE_PATH environment variables.
This enables running Playwright tests in the development environment.
* build: switch CI to use Biome for linting and formatting
- Update CI workflow to run lint, format, and typecheck commands directly
- Add unittest script in package.json and devenv.nix for consistency
- Update test:all to use unittest instead of bun test
* ci: update workflow for Biome integration
- Use 'unittest' script instead of 'bun test' for consistency in devenv job
- Temporarily disable Magic Nix Cache (commented out)
* ci: remove commented Magic Nix Cache steps
* docs: update documentation and configuration for Biome linting/formatting
- Add AGENTS.md with comprehensive project guidelines including Biome-specific rules
- Update README.md with corrected slash commands and build instructions
- Include AGENTS.md in OpenCode instructions
* docs: add note about bun command failures on NixOS
* ci: remove unnecessary id-token permission from Devenv CI job
The permission was added for FlakeHub cache authentication, but the job
does not use FlakeHub. Removing to avoid granting excessive permissions.
* ci: switch workflow to use bun commands directly
Remove devenv scripts and update CI to call bun commands explicitly,
integrating Biome for linting and formatting.
* chore: remove AGENTS.md and update instructions
Remove the AGENTS.md file which contained detailed guidelines for agents,
and update .opencode/opencode.json to remove it from the instructions array,
consolidating agent instructions into README.md.
* style: apply biome formatting and minor fixes to test files
- Sort imports in test files according to biome rules
- Increase timeouts in e2e tests for stability
- Add NaN check in port parsing to prevent errors
* style: format code with biome
* docs: add unit and e2e test commands to README
- Added bun unittest command for running unit tests
- Added bun test:e2e command for running end-to-end tests1 parent c555875 commit 56952cc
52 files changed
Lines changed: 1009 additions & 1106 deletions
File tree
- .github/workflows
- .opencode/command
- src
- plugin/pty
- tools
- web
- client
- components
- hooks
- server/handlers
- test
- e2e
- e2e
- ui
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| 61 | + | |
66 | 62 | | |
67 | 63 | | |
68 | | - | |
69 | 64 | | |
70 | 65 | | |
71 | 66 | | |
72 | 67 | | |
73 | 68 | | |
74 | 69 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 70 | + | |
| 71 | + | |
79 | 72 | | |
80 | 73 | | |
81 | 74 | | |
82 | 75 | | |
83 | 76 | | |
84 | 77 | | |
85 | 78 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
| 79 | + | |
| 80 | + | |
91 | 81 | | |
92 | | - | |
93 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
28 | | - | |
29 | | - | |
30 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
31 | 32 | | |
32 | | - | |
33 | | - | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
43 | 57 | | |
44 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
45 | 64 | | |
46 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
47 | 68 | | |
48 | 69 | | |
49 | 70 | | |
50 | | - | |
| 71 | + | |
51 | 72 | | |
52 | 73 | | |
53 | 74 | | |
54 | | - | |
| 75 | + | |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
298 | 299 | | |
299 | 300 | | |
300 | 301 | | |
301 | | - | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
302 | 305 | | |
| 306 | + | |
| 307 | + | |
303 | 308 | | |
304 | 309 | | |
305 | 310 | | |
| |||
0 commit comments