Remove process error listener in cleanupListeners

Author: felixweinberger

packages/client/src/client/stdio.ts

@@ -97,6 +97,7 @@ export class StdioClientTransport implements Transport {
     private _stderrStream: PassThrough | null = null;
     private _onServerDataHandler?: (chunk: Buffer) => void;
     private _onServerErrorHandler?: (error: Error) => void;
+    private _onProcessErrorHandler?: (error: Error) => void;
 
     onclose?: () => void;
     onerror?: (error: Error) => void;
@@ -144,10 +145,11 @@ export class StdioClientTransport implements Transport {
             this._process.stdout?.on('error', this._onServerErrorHandler);
             this._process.stdin?.on('error', this._onServerErrorHandler);
 
-            this._process.on('error', error => {
+            this._onProcessErrorHandler = error => {
                 reject(error);
                 this.onerror?.(error);
-            });
+            };
+            this._process.on('error', this._onProcessErrorHandler);
             this._process.once('spawn', () => resolve());
             this._process.once('close', _code => {
                 if (this._process) {
@@ -210,6 +212,9 @@ export class StdioClientTransport implements Transport {
             process.stdout?.off('error', this._onServerErrorHandler);
             process.stdin?.off('error', this._onServerErrorHandler);
         }
+        if (this._onProcessErrorHandler) {
+            process.off('error', this._onProcessErrorHandler);
+        }
     }
 
     async close(): Promise<void> {

packages/client/test/client/crossSpawn.test.ts

@@ -200,6 +200,7 @@ describe('StdioClientTransport using cross-spawn', () => {
         expect(stdout.listenerCount('data')).toBe(1);
         expect(stdout.listenerCount('error')).toBe(1);
         expect(stdin.listenerCount('error')).toBe(1);
+        expect(proc.listenerCount('error')).toBe(1);
 
         const closed = transport.close();
         proc.exitCode = 0;
@@ -209,6 +210,7 @@ describe('StdioClientTransport using cross-spawn', () => {
         expect(stdout.listenerCount('data')).toBe(0);
         expect(stdout.listenerCount('error')).toBe(0);
         expect(stdin.listenerCount('error')).toBe(0);
+        expect(proc.listenerCount('error')).toBe(0);
     });
 
     describe('windowsHide', () => {