perf(watcher): optimize wildcard matching#101
Conversation
…pound regexes Split wildcard ignore patterns into simple (no slashes) and compound (with slashes) regexes. This prevents redundant evaluations of simple wildcards against cumulative path prefixes, and compound wildcards against simple directory components, thereby improving performance in the file event hot path. Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Looks good, merging this in. CI is green and everything checks out 👍 Optimize wildcard matching by splitting ignore patterns into simple and compound regexes for faster file event processing. |
Acknowledged. |
1 participant
Split wildcard ignore patterns into simple (no slashes) and compound (with slashes) regexes. This prevents redundant evaluations of simple wildcards against cumulative path prefixes, and compound wildcards against simple directory components, thereby improving performance in the file event hot path.
PR created automatically by Jules for task 14314404888012082329 started by @shenald-dev