fix: gracefully handle undefined req.body#10
Conversation
When non-JSON content types are sent, express.json() does not parse the body, resulting in `req.body` being undefined. Trying to destructure properties directly from it causes a TypeError and crashes the server with a 500 error.
Added a fallback (`|| {}`) during destructuring to handle this case cleanly and return a 400 Bad Request instead. Also added tests to ensure this robustness.
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an issue where the API server would crash with a 500 Internal Server Error when a request was sent with an unparseable content-type or undefined body. It gracefully defaults to returning a 400 Bad Request error. Also includes tests to prevent regression.
PR created automatically by Jules for task 7612221067731788219 started by @shenald-dev