Fix X-Powered-By header leak on bypassed endpoints#102
Conversation
…passed endpoints Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
PR is clean and addresses the header leak effectively. Consider adding a brief comment in src/index.js explaining why x-powered-by is disabled for future maintainers. Reviewed — quality: high |
|
Looks good, merging this in. CI is green and everything checks out 👍 Disables X-Powered-By header globally to prevent leakage from bypassed endpoints and adds a regression test. |
Thanks for the review. I've added a comment in |
Acknowledged. |
Disables the
X-Powered-Byheader explicitly at the application level insrc/index.jsusingapp.disable('x-powered-by'). This addresses an issue where the/healthendpoint, which intentionally bypassedhelmet()for performance reasons, was leaking the framework identity. This change also eliminates the minor CPU overhead of allocating and setting the header only for it to be stripped later by downstream middlewares. Added a regression test to ensure/healthno longer returns the header.PR created automatically by Jules for task 3282943813695483731 started by @shenald-dev