Skip to content

perf: cache CORS preflight OPTIONS requests with maxAge#104

Open
shenald-dev wants to merge 5 commits intomasterfrom
jules-bolt-cors-maxage-7521502973374488087
Open

perf: cache CORS preflight OPTIONS requests with maxAge#104
shenald-dev wants to merge 5 commits intomasterfrom
jules-bolt-cors-maxage-7521502973374488087

Conversation

@shenald-dev
Copy link
Copy Markdown
Owner

Configured the CORS middleware to include a maxAge of 86400 seconds (24 hours). This instructs browsers to cache preflight OPTIONS requests, preventing redundant requests and reducing backend processing and latency.

  • Verified test suite passes, and added assertions to test the Access-Control-Max-Age header.
  • Bumped package version and documented release notes.

PR created automatically by Jules for task 7521502973374488087 started by @shenald-dev

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@shenald-dev shenald-dev added the documentation Improvements or additions to documentation label May 2, 2026
@shenald-dev
Copy link
Copy Markdown
Owner Author

Looks good, merging this in. CI is green and everything checks out 👍

Add CORS maxAge header to cache preflight OPTIONS requests for 24 hours.

@shenald-dev shenald-dev added the enhancement New feature or request label May 2, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Looks good, merging this in. CI is green and everything checks out 👍

Add CORS maxAge header to cache preflight OPTIONS requests for 24 hours.

Acknowledged.

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@shenald-dev
Copy link
Copy Markdown
Owner Author

@shenald-dev this PR has merge conflicts with master that I tried to fix but they're a bit complex.

To resolve manually:

git checkout jules-bolt-cors-maxage-7521502973374488087
git fetch origin && git merge origin/master
# resolve conflicts, then commit and push

Alternatively, you can try updating your branch with the latest from master if the conflicts are straightforward.

@shenald-dev
Copy link
Copy Markdown
Owner Author

Please resolve the merge conflicts with master before merging. Consider rebasing onto latest master and ensure the version bump follows semantic versioning. After conflicts are resolved, this PR looks good to merge.

Reviewed — quality: high

@google-labs-jules
Copy link
Copy Markdown
Contributor

@shenald-dev this PR has merge conflicts with master that I tried to fix but they're a bit complex.

To resolve manually:

git checkout jules-bolt-cors-maxage-7521502973374488087
git fetch origin && git merge origin/master
# resolve conflicts, then commit and push

Alternatively, you can try updating your branch with the latest from master if the conflicts are straightforward.

I have successfully merged origin/master into the branch and manually resolved the complex merge conflicts within .jules/warden.md.

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@shenald-dev
Copy link
Copy Markdown
Owner Author

🔄 Re-evaluating based on recent changes:

Please resolve the merge conflicts with master (as described in the comments) and ensure the version bump in package.json follows semantic versioning. After conflicts are resolved, the PR is ready to merge.

Reviewed — quality: high

@google-labs-jules
Copy link
Copy Markdown
Contributor

🔄 Re-evaluating based on recent changes:

Please resolve the merge conflicts with master (as described in the comments) and ensure the version bump in package.json follows semantic versioning. After conflicts are resolved, the PR is ready to merge.

Reviewed — quality: high

I have successfully merged origin/master and manually resolved all merge conflicts. The package.json was successfully bumped to 1.1.30 in a prior commit, which adheres to semantic versioning. The branch is clean and ready.

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@shenald-dev
Copy link
Copy Markdown
Owner Author

🔄 Re-evaluating based on recent changes:

Please resolve the merge conflicts with master (e.g., rebase onto latest master) and ensure the version bump follows semantic versioning. After conflicts are resolved, the PR is ready to merge.

Reviewed — quality: high

@google-labs-jules
Copy link
Copy Markdown
Contributor

🔄 Re-evaluating based on recent changes:

Please resolve the merge conflicts with master (e.g., rebase onto latest master) and ensure the version bump follows semantic versioning. After conflicts are resolved, the PR is ready to merge.

Reviewed — quality: high

I have previously successfully merged origin/master and completely resolved all merge conflicts, including a manual resolution for .jules/warden.md. The package.json was correctly bumped to 1.1.30 following semver in a prior commit. There are no remaining conflicts and the branch is clean. Re-submitting to ensure the CI picks up the latest state.

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant