Skip to content

sites: include HTTP status + body snippet in data-fetch error #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisJr404 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sites: include HTTP status + body snippet in data-fetch error #2940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions sherlock_project/sites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,16 @@ def __init__(
)

if response.status_code != 200:
raise FileNotFoundError(f"Bad response while accessing "
f"data file URL '{data_file_path}'."
)
# Include the status code and a short body snippet so users
# can tell the difference between e.g. a 404 (URL moved),
# 5xx (host outage), or a captive-portal HTML page.
body_snippet = response.text[:200].strip()
raise FileNotFoundError(
f"Bad response while accessing data file URL "
f"'{data_file_path}': HTTP {response.status_code} "
f"{response.reason}. "
f"Response body starts with: {body_snippet!r}"
)
try:
site_data = response.json()
except Exception as error:
Expand Down