Skip to content

Commit d62ebd9

Browse files
authored
Merge pull request #49 from shiftcode/#48-rename-logger-service
Rename LoggerService to BaseLoggerService
2 parents 1f751e3 + adcdf21 commit d62ebd9

6 files changed

Lines changed: 14 additions & 14 deletions

File tree

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/logger/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ messages to various transports.
99
# Usage
1010

1111
````typescript
12-
import { Logger, LogLevel, LogTransport } from '@shiftcode/logger'
12+
import { Logger, LogLevel, LogTransport, BaseLoggerService } from '@shiftcode/logger'
1313

1414
// Create a transport for logging to the console with a specific log level
1515
const transport = new LogTransport(
1616
LogLevel.DEBUG, // This controls the minimum log level
1717
)
1818

19-
// LoggerService is used to manage loggers and their transports
20-
const loggerService = new LoggerService([transport])
19+
// BaseLoggerService is used to manage loggers and their transports
20+
const baseLoggerService = new BaseLoggerService([transport])
2121

2222
// Create a logger instance with a specific name and color
23-
const logger = loggerService.getInstance('MyLogger', '#abcdef')
23+
const logger = baseLoggerService.getInstance('MyLogger', '#abcdef')
2424

2525
// Logging messages at different levels
2626
logger.debug('This is a debug message')

packages/logger/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@shiftcode/logger",
3-
"version": "2.0.0",
3+
"version": "3.0.0-pr48.1",
44
"description": "logger for local and aws lambda execution",
55
"repository": "https://github.com/shiftcode/sc-commons-public",
66
"license": "UNLICENSED",

packages/logger/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ export * from './model/log-transport.js'
44
export * from './model/json-log-transport.js'
55
export * from './model/json-log-object-data.js'
66

7-
export * from './services/logger.service.js'
7+
export * from './services/base-logger.service.js'
88

99
export * from './utils/logger-helper.js'

packages/logger/src/services/logger.service.spec.ts renamed to packages/logger/src/services/base-logger.service.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
import { SpyLogTransport } from '../../test/spy-log.transport.js'
2-
import { LoggerService } from './logger.service.js'
2+
import { BaseLoggerService } from './base-logger.service.js'
33
import { LogLevel } from '../model/log-level.enum.js'
44
import { Logger } from '../model/logger.js'
55

6-
describe('LoggerService with SpyLogTransport', () => {
6+
describe('BaseLoggerService with SpyLogTransport', () => {
77
it('should use the spy log transport', () => {
8-
const loggerService = new LoggerService([new SpyLogTransport(LogLevel.DEBUG)])
9-
const logger: Logger = loggerService.getInstance('MyLogger', '#abcdef')
8+
const baseLoggerService = new BaseLoggerService([new SpyLogTransport(LogLevel.DEBUG)])
9+
const logger: Logger = baseLoggerService.getInstance('MyLogger', '#abcdef')
1010
expect(logger['loggerTransports'][0] instanceof SpyLogTransport).toBeTruthy()
1111
expect(logger['loggerTransports'][0]['logLevel']).toBe(LogLevel.DEBUG)
1212
})
1313

1414
it('should have the custom name and color passed to the logger service', () => {
15-
const loggerService = new LoggerService([new SpyLogTransport(LogLevel.DEBUG)])
16-
const logger: Logger = loggerService.getInstance('MyLogger', '#abcdef')
15+
const baseLoggerService = new BaseLoggerService([new SpyLogTransport(LogLevel.DEBUG)])
16+
const logger: Logger = baseLoggerService.getInstance('MyLogger', '#abcdef')
1717
expect(logger['name']).toBe('MyLogger')
1818
expect(logger['color']).toBe('#abcdef')
1919
})

packages/logger/src/services/logger.service.ts renamed to packages/logger/src/services/base-logger.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Logger } from '../model/logger.js'
22
import { stringToColor } from '../utils/logger-helper.js'
33
import { LogTransport } from '../model/log-transport.js'
44

5-
export class LoggerService {
5+
export class BaseLoggerService {
66
private loggers = new Map<string, number>()
77

88
constructor(private readonly logTransports: LogTransport[]) {}

0 commit comments

Comments
 (0)