Revert "feat(cloud-watch-logger): use the beacon api"

This reverts commit e980b7b.

Author: mumenthalers

libs/core/src/lib/logger/cloud-watch-log/cloud-watch-log-api.service.ts

@@ -1,6 +1,7 @@
 // eslint-disable-next-line max-classes-per-file
 import { inject, Injectable } from '@angular/core'
-import { CommonHttpHeader, ContentType } from '@shiftcode/utilities'
+import { ContentType } from '@shiftcode/utilities'
+import { CommonHttpHeader } from '@shiftcode/utilities'
 
 import { CLOUD_WATCH_LOG_V2_CONFIG } from './cloud-watch-log-config.injection-token'
 
@@ -69,17 +70,14 @@ export class CloudWatchLogV2ApiService {
     return (await result.json()) as LogStream
   }
 
-  writeLogs(logStreamName: string, logs: LogEvent[]): Promise<void> {
-    const url = new URL(`${ApiPath.STREAMS}/${logStreamName}/${ApiPath.STREAM_LOGS}`, this.apiUrl)
-
-    // since the sendBeacon does not support providing headers directly,
-    //   we use a blob, to achieve the same effect (content-type application/json)
-    const data = new Blob([JSON.stringify({ logEvents: logs } satisfies WriteLogEvents)], { type: 'application/json' })
-
-    // we use the beacon api to ensure log sending requests are not cancelled on page unload
-    const ok = navigator.sendBeacon(url, data)
-
-    return ok ? Promise.resolve() : Promise.reject(new Error('Failed to send logs via sendBeacon'))
+  async writeLogs(logStreamName: string, logs: LogEvent[]): Promise<void> {
+    // todo: use beaconApi ?
+    const resp = await fetch(new URL(`${ApiPath.STREAMS}/${logStreamName}/${ApiPath.STREAM_LOGS}`, this.apiUrl), {
+      method: 'POST',
+      headers: { [CommonHttpHeader.CONTENT_TYPE]: ContentType.JSON },
+      body: JSON.stringify({ logEvents: logs } satisfies WriteLogEvents),
+    })
+    await this.handleError(resp)
   }
 
   private async handleError(resp: Response): Promise<void> {

libs/core/src/lib/logger/cloud-watch-log/cloud-watch-log.service.ts

@@ -30,8 +30,8 @@ export class CloudWatchLogV2Service {
 
   private readonly logRequestInfoFn = inject(LOG_REQUEST_INFO_FN, { optional: true })
   private readonly config = inject(CLOUD_WATCH_LOG_V2_CONFIG)
-  private readonly jsonStringifyReplacer = this.config.jsonStringifyReplacer ?? jsonMapSetStringifyReplacer
-  private readonly bufferSize = this.config.bufferSize ?? 100
+  private readonly jsonStringifyReplacer = this.config.jsonStringifyReplacer || jsonMapSetStringifyReplacer
+  private readonly bufferSize = this.config.bufferSize || 100
 
   /** Ring buffer for log events below the configured level, flushed on ERROR */
   private pendingBuffer: LogEvent[] = []
@@ -145,7 +145,7 @@ export class CloudWatchLogV2Service {
     // outer observable only for retry logic -- see below
     return defer(() => this.api.writeLogs(this.clientId, events)).pipe(
       catchError((err) => {
-        console.error('unable to put logs to CloudWatch --> we try again with the next batch', err)
+        console.warn('unable to put logs to CloudWatch --> we try again with the next batch', err)
         return of(void 0)
       }),
     )