feat(storybook): improve rem font sizing for mobile#76
Open
shijistar wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Storybook typography scaling—moving custom docs/demo styles to rem and increasing the preview iframe’s root font-size on narrow viewports—so text remains readable on mobile, including Ant Design portal-based overlays that render outside .enum-story-shell.
Changes:
- Convert Storybook custom docs/demo font-size declarations from
pxtorem. - Increase the preview iframe
:rootfont-size for mobile breakpoints to improve readability. - Add mobile-only font-size targeting for Ant Design portal overlays mounted outside
.enum-story-shell.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.storybook/story-styles.css |
Switches many sizes to rem, bumps iframe root font size on small screens, and adds mobile overlay font-size rules for Ant Design portal content. |
.storybook/global-styles.css |
Converts sidebar font sizing to rem and increases it on small screens for better manager UI readability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+5
| text-size-adjust: 100%; | ||
| text-size-adjust: 100%; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.enum-story-shellValidation
npm run build-storybook