Test PhpatUsageProvider via DeadCodeRuleTest integration fixture

Replace the standalone PhpatUsageProviderTest with the conventional
integration fixture used by every other provider: a real
data/providers/phpat.php with a registered and an unregistered phpat
architecture test, driven through DeadCodeRuleTest.

The container mock now returns an instance of the registered test for the
"phpat.test" tag, mirroring phpat's getServicesByTag() lookup, so detection
is exercised end-to-end against the dead-code graph. testNoFatalError uses
require_once since the fixture classes are autoloaded during analysis.

Co-Authored-By: Claude Code
Claude-Session: https://claude.ai/code/session_01WqA3SLHn3vQEytN5C1KCJj

Author: janedbal

composer-dependency-analyser.php

@@ -11,7 +11,6 @@
 $config = (new Configuration())
     ->ignoreErrorsOnPath(__DIR__ . '/src/Provider', [ErrorType::DEV_DEPENDENCY_IN_PROD]) // providers are designed that way
     ->ignoreErrorsOnExtensionAndPath('ext-simplexml', __DIR__ . '/src/Provider/SymfonyUsageProvider.php', [ErrorType::SHADOW_DEPENDENCY]) // guarded with extension_loaded()
-    ->addPathToExclude(__DIR__ . '/tests/Provider/data')
     ->addPathToExclude(__DIR__ . '/tests/Rule/data');
 
 return $config;

composer.json

@@ -66,7 +66,6 @@
             "ShipMonk\\PHPStan\\DeadCode\\": "tests/"
         },
         "classmap": [
-            "tests/Provider/data",
             "tests/Rule/data"
         ]
     },

tests/Excluder/TestsUsageExcluderTest.php

@@ -19,7 +19,6 @@ public function testAutodetectComposerDevPaths(): void
 
         self::assertSame([
             realpath(__DIR__ . '/../../tests'),
-            realpath(__DIR__ . '/../../tests/Provider/data'),
             realpath(__DIR__ . '/../../tests/Rule/data'),
         ], $devPathsPropertyReflection->getValue($excluder));
     }

tests/Provider/PhpatUsageProviderTest.php

@@ -7,6 +7,7 @@
 use Composer\Semver\VersionParser;
 use Generator;
 use LogicException;
+use PhpatProvider\RegisteredArchitectureTest;
 use PhpParser\Node;
 use PHPStan\Analyser\Error;
 use PHPStan\Analyser\Scope;
@@ -235,7 +236,7 @@ public function testNoFatalError(): void
 
                 try {
                     ob_start();
-                    require $file;
+                    require_once $file;
                     ob_end_clean();
                 } catch (Throwable $e) {
                     self::fail("Fatal error in {$e->getFile()}:{$e->getLine()}:\n {$e->getMessage()}");
@@ -1015,6 +1016,7 @@ public static function provideFiles(): Traversable
         yield 'provider-behat' => [__DIR__ . '/data/providers/behat.php'];
         yield 'provider-doctrine' => [__DIR__ . '/data/providers/doctrine.php'];
         yield 'provider-phpstan' => [__DIR__ . '/data/providers/phpstan.php'];
+        yield 'provider-phpat' => [__DIR__ . '/data/providers/phpat.php', self::requiresPackage('phpat/phpat', '>= 0.12')];
         yield 'provider-eloquent' => [__DIR__ . '/data/providers/eloquent.php'];
         yield 'provider-laravel' => [__DIR__ . '/data/providers/laravel.php'];
         yield 'provider-blade' => [__DIR__ . '/data/providers/blade.php'];
@@ -1374,7 +1376,11 @@ static function (string $type): array {
                 },
             );
         $mock->method('getServicesByTag')
-            ->willReturn([]);
+            ->willReturnCallback(
+                static fn (string $tag): array => $tag === 'phpat.test'
+                    ? [new RegisteredArchitectureTest()]
+                    : [],
+            );
         return $mock;
     }
 

tests/Provider/data/phpat.php

@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace PhpatProvider;
+
+use PHPat\Selector\Selector;
+use PHPat\Test\Attributes\TestRule;
+use PHPat\Test\Builder\Rule;
+use PHPat\Test\PHPat;
+
+// Registered via the "phpat.test" service tag (see DeadCodeRuleTest container mock).
+// phpat invokes its public test* / #[TestRule] methods, so they are not dead.
+class RegisteredArchitectureTest
+{
+
+    public function testSrcShouldNotDependOnTests(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::AllOf())
+            ->shouldNotDependOn()
+            ->classes(Selector::AllOf());
+    }
+
+    #[TestRule]
+    public function customNamedRule(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::AllOf())
+            ->shouldNotDependOn()
+            ->classes(Selector::AllOf());
+    }
+
+    public function unusedHelper(): void // error: Unused PhpatProvider\RegisteredArchitectureTest::unusedHelper
+    {
+    }
+
+}
+
+// Not registered as a phpat test → its test method really is dead.
+class UnregisteredArchitectureTest
+{
+
+    public function testOrphanRule(): Rule // error: Unused PhpatProvider\UnregisteredArchitectureTest::testOrphanRule
+    {
+        return PHPat::rule()
+            ->classes(Selector::AllOf())
+            ->shouldNotDependOn()
+            ->classes(Selector::AllOf());
+    }
+
+}