PHPUnit: Fix cross-class @dataProvider annotation not being resolved (#338)

Author: janedbal

src/Provider/PhpUnitUsageProvider.php

@@ -14,8 +14,10 @@
 use ShipMonk\PHPStan\DeadCode\Graph\ClassMethodRef;
 use ShipMonk\PHPStan\DeadCode\Graph\ClassMethodUsage;
 use ShipMonk\PHPStan\DeadCode\Graph\UsageOrigin;
-use function array_merge;
+use function count;
+use function explode;
 use function is_string;
+use function ltrim;
 use function str_contains;
 use function str_starts_with;
 
@@ -61,15 +63,24 @@ public function getUsages(
             $methodName = $method->getName();
 
             $externalDataProviderMethods = $this->getExternalDataProvidersFromAttributes($method);
-            $localDataProviderMethods = array_merge(
-                $this->getDataProvidersFromAnnotations($method->getDocComment()),
-                $this->getDataProvidersFromAttributes($method),
-            );
+            $annotationDataProviders = $this->getDataProvidersFromAnnotations($method->getDocComment());
+            $localDataProviderMethods = $this->getDataProvidersFromAttributes($method);
 
             foreach ($externalDataProviderMethods as [$externalClassName, $externalMethodName]) {
                 $usages[] = $this->createUsage($externalClassName, $externalMethodName, "External data provider method, used by $className::$methodName");
             }
 
+            foreach ($annotationDataProviders as $dataProvider) {
+                $parts = explode('::', $dataProvider, 2);
+
+                if (count($parts) === 2) {
+                    $providerClassName = ltrim($parts[0], '\\');
+                    $usages[] = $this->createUsage($providerClassName, $parts[1], "External data provider method (annotation), used by $className::$methodName");
+                } else {
+                    $usages[] = $this->createUsage($className, $dataProvider, "Data provider method, used by $methodName");
+                }
+            }
+
             foreach ($localDataProviderMethods as $dataProvider) {
                 $usages[] = $this->createUsage($className, $dataProvider, "Data provider method, used by $methodName");
             }

tests/Rule/data/providers/phpunit.php

@@ -25,6 +25,11 @@ public static function provideTwo(): array
     {
         return [];
     }
+
+    public static function provideViaAnnotation(): array
+    {
+        return [];
+    }
 }
 
 class SomeTest extends TestCase
@@ -60,6 +65,13 @@ public function testBar(string $arg): void
     {
     }
 
+    /**
+     * @dataProvider \PhpUnit\ExternalProvider::provideViaAnnotation
+     */
+    public function testExternalViaAnnotation(string $arg): void
+    {
+    }
+
     #[Test]
     public function someTestCase(): void
     {