Support nested #[MapInput] in console command DTOs

Recurse into DTO properties annotated with #[MapInput] so their
reported as dead. The host property is marked read+written.

Author: janedbal

src/Provider/SymfonyUsageProvider.php

@@ -686,12 +686,24 @@ private function getMapInputUsages(InClassMethodNode $node): array
 
     /**
      * @param list<ClassMethodUsage|ClassPropertyUsage> $usages
+     * @param array<string, true> $visited
      */
     private function collectMapInputDtoUsages(
         string $dtoClassName,
         array &$usages,
+        array &$visited = [],
     ): void
     {
+        if (isset($visited[$dtoClassName])) {
+            return;
+        }
+
+        $visited[$dtoClassName] = true;
+
+        if (!$this->reflectionProvider->hasClass($dtoClassName)) {
+            return;
+        }
+
         $dtoReflection = $this->reflectionProvider->getClass($dtoClassName);
         $origin = UsageOrigin::createVirtual($this, VirtualUsageData::withNote('Console input DTO via #[MapInput]'));
 
@@ -702,8 +714,9 @@ private function collectMapInputDtoUsages(
 
             $isInputProperty = $property->getAttributes('Symfony\Component\Console\Attribute\Argument') !== []
                 || $property->getAttributes('Symfony\Component\Console\Attribute\Option') !== [];
+            $nestedMapInput = $property->getAttributes('Symfony\Component\Console\Attribute\MapInput') !== [];
 
-            if (!$isInputProperty) {
+            if (!$isInputProperty && !$nestedMapInput) {
                 continue;
             }
 
@@ -717,6 +730,18 @@ private function collectMapInputDtoUsages(
                 new ClassPropertyRef($dtoClassName, $property->getName(), possibleDescendant: false),
                 AccessType::READ,
             );
+
+            if (!$nestedMapInput) {
+                continue;
+            }
+
+            $propertyType = $property->getType();
+
+            if (!$propertyType instanceof ReflectionNamedType || $propertyType->isBuiltin()) {
+                continue;
+            }
+
+            $this->collectMapInputDtoUsages($propertyType->getName(), $usages, $visited);
         }
 
         foreach ($dtoReflection->getNativeReflection()->getMethods() as $dtoMethod) {

tests/Rule/data/providers/symfony.php

@@ -265,3 +265,37 @@ class OrphanedInput {
     #[Interact]
     public function askSomething(): void {} // error: Unused Symfony\OrphanedInput::askSomething
 }
+
+class NestedFiltersInput {
+    #[\Symfony\Component\Console\Attribute\Argument]
+    public string $tag;
+
+    #[\Symfony\Component\Console\Attribute\Option]
+    public bool $strict = false;
+
+    public string $notAnInput; // error: Property Symfony\NestedFiltersInput::$notAnInput is never read // error: Property Symfony\NestedFiltersInput::$notAnInput is never written
+
+    #[Interact]
+    public function askForTag(): void {}
+
+    public function deadOnNested(): void {} // error: Unused Symfony\NestedFiltersInput::deadOnNested
+}
+
+class WrappedImportInput {
+    #[\Symfony\Component\Console\Attribute\Argument]
+    public string $name;
+
+    #[\Symfony\Component\Console\Attribute\MapInput]
+    public NestedFiltersInput $filters;
+}
+
+#[AsCommand(name: 'app:import-wrapped')]
+class WrappedImportCommand extends Command {
+    public function __invoke(
+        #[\Symfony\Component\Console\Attribute\MapInput] WrappedImportInput $input,
+    ): int {
+        echo $input->name;
+        echo $input->filters->tag;
+        return 0;
+    }
+}