Blade extension consuming too much resources

[calebdw]

Hello!

• PHP: 8.5
• Laravel: 12.x
• PHPStan: 2.1.x

First off, thanks for this project, I'm looking forward to using it.

However, I'm trying to get this running on my work project and it just...crashes. Not really sure how to help debug, I've just installed it and am using the default configuration (I have the extension-installer installed, so no phpstan config changes)

$ sail bin phpstan -vvv
Note: Using configuration file /var/www/html/phpstan.neon.
Result cache not used because the cache file does not exist.
 4634/4634 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 7 mins/7 mins

Result cache is saved.
<crashes after this>

Note: using this extension has 2-3x the time it takes phpstan to run and my computer gets sluggish right before it crashes which would seem to indicate a memory leak / OOM issue....I wonder if there's a way to make this package more performant?

Thanks!

[calebdw]

Update: I reran this with the --debug -vvv flags and I get the same thing---a crash at the end with no information:

/var/www/html/tests/Architecture/Rules/PromotedPropertiesRule.php
--- consumed 0 B, total 3.36 GB, took 0.16 s, 646.714 LoC/s
/var/www/html/tests/Architecture/Rules/ValidationModelClassStringRule.php
--- consumed 0 B, total 3.36 GB, took 0.05 s, 1353.120 LoC/s
Result cache is saved.
<crashes after this>

[janedbal]

How big is the codebase? Can you give it more RAM to test if it succeeds?

Few more ideas:

• Everything is happening in this rule, so you can place breakpoints/dumps there to see where it gets
  

[calebdw]

Can you give it more RAM to test if it succeeds?

No, the system has 32GB of ram---it's not PHP killing it but the OS (if that's why it's crashing)

[janedbal]

Few more blind ideas:

• try force-disabling some providers
  • it would give you ton of false positives, but it could lead us somewhere

parameters:
    shipmonkDeadCode:
        usageProviders:
            eloquent:
                enabled: false
            laravel:
                enabled: false
            blade:
                enabled: false

• try disabling some analysis:

parameters:
    shipmonkDeadCode:
        detect:
            deadConstants: false
            deadEnumCases: false
            deadProperties:
                neverRead: false
                neverWritten: false

• try legacy cache mode

parameters:
    shipmonkDeadCode:
        cache:
            offloadCollectorData: false

But I'm not giving that much chances. Breakpoint is the best approach.

[calebdw]

Hmm, added some debugging and found that it's not getting past this loop:

dead-code-detector/src/Rule/DeadCodeRule.php

Lines 181 to 199 in 74e7ddf

	foreach ($memberUseData as $file => $usesPerFile) {
	foreach ($usesPerFile as $hashes) {
	foreach ($hashes as $hash) {
	foreach ($this->usageCacheStorage->unpack($hash, $file) as $collectedUsage) {
	$memberUsage = $collectedUsage->getUsage();
	$className = $memberUsage->getMemberRef()->getClassName();
	$memberName = $memberUsage->getMemberRef()->getMemberName();
	if ($className === null) {
	$memberNameString = $memberName ?? DebugUsagePrinter::ANY_MEMBER;
	$this->mixedClassNameUsages[$memberUsage->getMemberType()->value][$memberNameString][] = $collectedUsage;
	continue;
	}
	$knownCollectedUsages[] = $collectedUsage;
	}
	}
	}
	}

[janedbal]

Note: using this extension has 2-3x the time it takes phpstan to run

Normally, DCD should not slow down the analysis much.

Measurements in phpstan-src (2300 files):

Metric	Without	With	Delta
Time (secs)	17.16	19.27	+2.11 (+12.30%)
Memory (GB)	2.66	2.71	+0.05 (+1.88%)

[janedbal]

Hmm, added some debugging and found that it's not getting past this loop:

This suggest massive amount of emitted usages. Can you try disabling laravel providers?

[calebdw]

Hmm, the culprit appears to be the blade provider---the analysis completes just fine (just with 2300+ errors lol) when this is disabled

phpstan also completes much faster when this is disabled

[janedbal]

Please test #350 if it helps (I have more ideas if it wont)

[calebdw]

It looks like that allowed it to complete:

• the actual analysis was much faster than before (but still a bit slower than without)
• however, the last portion after the analysis took much longer to complete than without it

[janedbal]

Can you share some snippets of code how you pass params to blade templates and how those params typically look like (classes)?

[calebdw]

Our most common way is to just call get_defined_vars():

    public function index(Request $request): View
    {
        $parameters = [];

        $faxes = Fax::query()
            ->filterUsingRequest($request, parameters: $parameters)
            ->sortUsingRequest($request, default: ['created_at' => 'desc'])
            ->paginate(50)
            ->withQueryString();

        $statuses = FaxStatus::toArray();

        return view('ems.faxes.index', get_defined_vars());
    }