Symfony: Add support for #[MapRequestPayload] and #[MapQueryString] DTOs#339
Draft
Symfony: Add support for #[MapRequestPayload] and #[MapQueryString] DTOs#339
Conversation
Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Symfony controller parameter uses
#[MapRequestPayload]or#[MapQueryString], the framework'sRequestPayloadValueResolveruses the serializer to create the DTO object. The DTO's constructor is called and its properties are populated — all invisible in user source code. This causes false positives where the DTO constructor, properties, and setter methods are reported as dead code.The serializer behavior depends on the normalizer used. With the default
ObjectNormalizer(registered at priority -1000 in Symfony's framework-bundle):setFoo()) are called via PropertyAccessorChanges
#[MapRequestPayload]and#[MapQueryString]attributes on controller method parametersset*) matching a property name as usedReflectionProviderdependency toSymfonyUsageProviderCo-Authored-By: Claude Code