Skip to content

Free the usage graph after emitting errors #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ondrejmirtes wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

Free the usage graph after emitting errors #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Rule/DeadCodeRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,19 @@ public function processNode(
}
}

return $this->processKnownCollectedUsages($knownCollectedUsages);
$errors = $this->processKnownCollectedUsages($knownCollectedUsages);

// the usage graph is the analysis output and has just been turned into errors;
// processNode(CollectedDataNode) runs once per process, so this state would
// otherwise stay allocated for the rest of the process (~90k objects on a
// 2.4k-file codebase). DebugUsagePrinter received its own copies earlier;
// $typeDefinitions and $mixedClassNameUsages are kept for print().
$this->traitMembers = [];
$this->memberAlternativesCache = [];
$this->blackMembers = [];
$this->usageGraph = [];

return $errors;
}

/**
Expand Down
Loading