Automatically delete orphaned baseline files#53
Merged
Conversation
JanTvrdik
force-pushed
the
auto-delete-orphaned-baselines
branch
from
3deba8d to
35e4be5
Compare
janedbal
reviewed
Dec 8, 2025
janedbal
approved these changes
Dec 8, 2025
The split-phpstan-baseline command now automatically deletes baseline files that no longer have corresponding errors in the generated baseline. This eliminates the need for the manual `find baselines/ -type f -not -name _loader.neon -delete` step before running the splitter. The deletion is extension-aware: only files with the same extension as the loader file are considered for deletion (e.g., .neon files when using a .neon loader).
JanTvrdik
force-pushed
the
auto-delete-orphaned-baselines
branch
from
35e4be5 to
547d79f
Compare
Contributor
|
awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split-phpstan-baselinecommand now automatically deletes baseline files that no longer have corresponding errorsfind baselines/ -type f -not -name _loader.neon -deletestepTest plan
testOrphanedFilesAreDeleted- verifies baseline files for removed identifiers are deletedtestLoaderFileIsNotDeleted- verifies the loader file is never deletedtestOnlyFilesWithMatchingExtensionAreDeleted- verifies only matching extensions are deleted