Upgrade PHPUnit to 10#60
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Available since PHPUnit 10.5.5, not 11.4 as previously assumed. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpunit/phpunitto^10.5.46(PHP 8.1+ allows it now after Drop PHP 7.4 and 8.0 support, modernize to PHP 8.1+ #59)phpunit.xml.distfor PHPUnit 10: drop deprecatedbeStrictAboutCoversAnnotation, addcacheDirectory,displayDetailsOn*, individualfailOn*flags, explicit<testsuites>, and<source restrictDeprecations restrictNotices restrictWarnings>IntegrationTest::testResultCachefrom@dataProviderto#[DataProvider]and makeprovideExtensionstatic (required by PHPUnit 10)SlevomatCodingStandard.Commenting.ForbiddenAnnotations.AnnotationForbiddenexclusion fromphpcs.xml.dist(only existed because PHPUnit 9 lacked#[DataProvider])Mirrors shipmonk-rnd/phpstan-rules#362.
Note:
failOnAllIssueswas considered but it was added in PHPUnit 11.4, which requires PHP 8.2+. Staying on PHP 8.1 means PHPUnit 10 is the cap, so individualfailOn*flags are used.Test plan
composer check:tests(18/18 pass on PHPUnit 10.5.63)composer check:cscomposer check:typescomposer check:dependenciescomposer check:composerCo-Authored-By: Claude noreply@anthropic.com