Finish fixing JS lint

Author: RobbieTheWagner

app/components/about.ts

@@ -23,7 +23,7 @@ export default class AboutComponent extends Component<AboutSignature> {
 
       this.ipcRenderer = ipcRenderer;
 
-      this.ipcRenderer.invoke('getAppVersion').then((version: string) => {
+      void this.ipcRenderer.invoke('getAppVersion').then((version: string) => {
         this.version = version;
       });
     }
@@ -34,7 +34,7 @@ export default class AboutComponent extends Component<AboutSignature> {
     event.preventDefault();
 
     if (typeof requireNode !== 'undefined') {
-      requireNode('electron').shell.openExternal('https://swach.io/');
+      void this.ipcRenderer.invoke('open-external', 'https://swach.io/');
     }
   }
 }

app/components/animated-drag-sort-list.ts

@@ -17,6 +17,7 @@ export default class AnimatedDragSortList extends DragSortList {
   @action
   rules(): unknown {
     if (!this.didDrag) {
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       return this.transition;
     }
 
@@ -25,6 +26,7 @@ export default class AnimatedDragSortList extends DragSortList {
     return null;
   }
 
+  // eslint-disable-next-line require-yield
   *transition({
     keptSprites,
     insertedSprites,

app/components/color-picker.ts

@@ -93,7 +93,7 @@ export default class ColorPickerComponent extends Component<ColorPickerSignature
 
       this.undoManager.setupUndoRedo();
     } else {
-      this.args.saveColor(this._selectedColor?.hex);
+      await this.args.saveColor(this._selectedColor?.hex);
     }
 
     this.args.toggleIsShown();

app/components/colors-list.ts

@@ -46,6 +46,7 @@ export default class ColorsListComponent extends Component<ColorsListSignature>
     return undefined;
   }
 
+  // eslint-disable-next-line require-yield
   *transition({
     keptSprites,
     insertedSprites,
@@ -73,7 +74,7 @@ export default class ColorsListComponent extends Component<ColorsListSignature>
   }
 
   @action
-  async deleteColor(color: ColorModel): Promise<void> {
+  async deleteColor(color: ColorModel){
     const { palette } = this.args;
 
     if (color && palette && !palette.isLocked) {

app/components/contrast-checker.ts

@@ -3,6 +3,7 @@ import type Owner from '@ember/owner';
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 
+import { type IroColorValue } from '@irojs/iro-core';
 import iro from '@jaames/iro';
 import type { IpcRenderer } from 'electron';
 import { hex, score } from 'wcag-contrast';
@@ -37,13 +38,19 @@ export default class ContrastChecker extends Component<ContrastCheckerSignature>
 
       this.ipcRenderer = ipcRenderer;
 
-      this.ipcRenderer.on('pickContrastBgColor', async (_event, color) => {
-        this.setBgColor(color);
-      });
+      this.ipcRenderer.on(
+        'pickContrastBgColor',
+        (_event, color: IroColorValue) => {
+          this.setBgColor(color);
+        },
+      );
 
-      this.ipcRenderer.on('pickContrastFgColor', async (_event, color) => {
-        this.setFgColor(color);
-      });
+      this.ipcRenderer.on(
+        'pickContrastFgColor',
+        (_event, color: IroColorValue) => {
+          this.setFgColor(color);
+        },
+      );
     }
   }
 
@@ -139,16 +146,14 @@ export default class ContrastChecker extends Component<ContrastCheckerSignature>
 
   @action
   onBlurBg(ev: Event) {
-    this.setBgColor((ev.target as HTMLInputElement).value);
+    this.setBgColor((ev.target as HTMLInputElement).value as IroColorValue);
   }
 
-  // TODO: correctly type this instead of using `any`
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  setBgColor(color: any) {
+  setBgColor(color: IroColorValue) {
     try {
       this.bgPickr.setColors([color]);
       this.backgroundColor = this.bgPickr.color.hexString;
-    } catch (err) {
+    } catch {
       // TODO: maybe mention the color is invalid here?
     }
   }
@@ -158,13 +163,11 @@ export default class ContrastChecker extends Component<ContrastCheckerSignature>
     this.setFgColor((ev.target as HTMLInputElement).value);
   }
 
-  // TODO: correctly type this instead of using `any`
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  setFgColor(color: any) {
+  setFgColor(color: IroColorValue) {
     try {
       this.fgPickr.setColors([color]);
       this.foregroundColor = this.fgPickr.color.hexString;
-    } catch (err) {
+    } catch {
       // TODO: maybe mention the color is invalid here?
     }
   }

app/components/loading-button.ts

@@ -8,6 +8,7 @@ interface LoadingButtonSignature {
   };
 }
 
+// eslint-disable-next-line ember/no-empty-glimmer-component-classes
 export default class LoadingButton extends Component<LoadingButtonSignature> {}
 
 declare module '@glint/environment-ember-loose/registry' {

app/controllers/application.ts

@@ -109,7 +109,7 @@ export default class ApplicationController extends Controller {
           const addedColor = await this.addColor(color);
 
           if (addedColor) {
-            this.colorUtils.copyColorToClipboard(addedColor);
+            await this.colorUtils.copyColorToClipboard(addedColor);
           }
         },
       );
@@ -122,7 +122,10 @@ export default class ApplicationController extends Controller {
         'openSharedPalette',
         // eslint-disable-next-line @typescript-eslint/no-misused-promises
         async (_event: unknown, query: string) => {
-          const data = JSON.parse(decodeURIComponent(query));
+          const data = JSON.parse(decodeURIComponent(query)) as {
+            colors?: { name: string; hex: string }[];
+            name?: string;
+          };
           const colors = data?.colors ?? [];
           const name = data?.name ?? 'Palette';
 

app/utils/view-transitions.ts

@@ -4,6 +4,7 @@ export default function viewTransitions() {
   }
 
   return new Promise<void>((resolve) => {
+    // eslint-disable-next-line @typescript-eslint/require-await
     document.startViewTransition(async () => {
       resolve();
     });

electron-app/src/index.js

@@ -2,6 +2,7 @@ const Sentry = require('@sentry/electron');
 const { ipcMain, nativeTheme } = require('electron');
 const isDev = require('electron-is-dev');
 const Store = require('electron-store');
+// eslint-disable-next-line no-redeclare
 const { menubar } = require('menubar');
 const { basename, dirname, join, resolve } = require('path');
 const { pathToFileURL } = require('url');

electron-app/src/ipc-events.js

@@ -1,4 +1,4 @@
-const { app, clipboard, dialog, ipcMain, nativeTheme } = require('electron');
+const { app, clipboard, dialog, ipcMain, nativeTheme, shell } = require('electron');
 const { download } = require('electron-dl');
 const fs = require('fs');
 
@@ -65,6 +65,10 @@ function setupEventHandlers(mb, store) {
     await launchPicker(mb);
   });
 
+  ipcMain.handle('open-external', async (_event, url) => {
+    await shell.openExternal(url);
+  });
+
   ipcMain.on('setShowDockIcon', async (channel, showDockIcon) => {
     store.set('showDockIcon', showDockIcon);
     await restartDialog();