Fix lint issues and ignore build artifacts

- Fix ESLint errors in supabase service (side-effects, unsafe return)
- Fix unused vars and unnecessary type assertions
- Convert register component to template-only
- Add electron-app/ember-test to lint ignore files (build artifacts)
- Format files with prettier

Author: chuckcarpenter

.prettierignore

@@ -4,6 +4,7 @@
 # compiled output
 /dist/
 /electron-app/dist/
+/electron-app/ember-test/
 /electron-app/magnifier/rust-sampler/target/
 
 # misc

.stylelintignore

@@ -3,6 +3,7 @@
 
 # compiled output
 /dist/
+/electron-app/ember-test/
 
 # Rust generated documentation
 **/target/doc/

app/authenticators/supabase.ts

@@ -44,6 +44,7 @@ export default class SupabaseAuthenticator extends BaseAuthenticator {
    * Restore session from Supabase's persisted storage.
    * Called on app startup to check if user is still logged in.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async restore(_data: SupabaseAuthData): Promise<SupabaseAuthData> {
     const session = await this.supabase.getSession();
 

app/components/login.gts

@@ -100,8 +100,8 @@ export default class LoginComponent extends Component {
         {{else}}
           {{! Email Entry Step }}
           <p class="text-menu-text text-sm mb-4">
-            Enter your email and we'll send you a code to sign in.
-            No password needed!
+            Enter your email and we'll send you a code to sign in. No password
+            needed!
           </p>
 
           <div class="mb-6">
@@ -201,8 +201,7 @@ export default class LoginComponent extends Component {
 
       this.router.transitionTo('settings.cloud.profile');
     } catch (error: unknown) {
-      this.errorMessage =
-        (error as Error).message || 'Invalid or expired code';
+      this.errorMessage = (error as Error).message || 'Invalid or expired code';
     } finally {
       this.loading = false;
     }

app/components/register.gts

@@ -1,48 +1,45 @@
 import { LinkTo } from '@ember/routing';
-import Component from '@glimmer/component';
 
 /**
  * With OTP authentication, there's no separate registration flow.
  * New users are automatically created when they verify their email.
  * This component just redirects users to the login flow.
  */
-export default class RegisterComponent extends Component {
-  <template>
-    <div class="bg-menu p-4 rounded-md w-full">
-      <div class="pt-4 w-full">
-        <h2 class="font-bold text-2xl">
-          Sign Up
-        </h2>
-      </div>
+<template>
+  <div class="bg-menu p-4 rounded-md w-full">
+    <div class="pt-4 w-full">
+      <h2 class="font-bold text-2xl">
+        Sign Up
+      </h2>
+    </div>
+
+    <div class="mt-4">
+      <p class="text-menu-text text-sm mb-4">
+        Getting started is easy! Just enter your email address and we'll send
+        you a code to sign in. No password required.
+      </p>
 
-      <div class="mt-4">
-        <p class="text-menu-text text-sm mb-4">
-          Getting started is easy! Just enter your email address and we'll send
-          you a code to sign in. No password required.
-        </p>
+      <p class="text-menu-text text-sm mb-6">
+        If you're a new user, your account will be created automatically.
+      </p>
 
-        <p class="text-menu-text text-sm mb-6">
-          If you're a new user, your account will be created automatically.
-        </p>
+      <LinkTo
+        @route="settings.cloud.login"
+        class="btn btn-primary w-full inline-block text-center"
+        data-test-register-continue
+      >
+        Continue with Email
+      </LinkTo>
 
+      <p class="mt-4 text-center text-menu-text text-sm">
+        Already have an account?
         <LinkTo
           @route="settings.cloud.login"
-          class="btn btn-primary w-full inline-block text-center"
-          data-test-register-continue
+          class="font-medium text-alt hover:text-alt-hover"
         >
-          Continue with Email
+          Sign in
         </LinkTo>
-
-        <p class="mt-4 text-center text-menu-text text-sm">
-          Already have an account?
-          <LinkTo
-            @route="settings.cloud.login"
-            class="font-medium text-alt hover:text-alt-hover"
-          >
-            Sign in
-          </LinkTo>
-        </p>
-      </div>
+      </p>
     </div>
-  </template>
-}
+  </div>
+</template>

app/data-sources/remote.ts

@@ -2,18 +2,17 @@ import { getOwner } from '@ember/application';
 
 import { applyStandardSourceInjections } from 'ember-orbit';
 
-import type { RealtimeChannel, SupabaseClient } from '@supabase/supabase-js';
-
 import { Orbit } from '@orbit/core';
 import { Source } from '@orbit/data';
 import type {
   InitializedRecord,
   RecordIdentity,
   RecordOperation,
+  RecordQuery,
   RecordSchema,
   RecordTransformResult,
 } from '@orbit/records';
-import type { RecordQuery } from '@orbit/records';
+import type { RealtimeChannel, SupabaseClient } from '@supabase/supabase-js';
 
 import type SessionService from '../services/session.ts';
 import type SupabaseService from '../services/supabase.ts';
@@ -114,7 +113,7 @@ export class SupabaseSource extends Source {
         const records = await this.findRecords(type);
         results.push(...records);
       } else if (expression.op === 'findRecord') {
-        const record = expression.record as RecordIdentity;
+        const record = expression.record;
         const result = await this.findRecord(record.type, record.id);
         if (result) results.push(result);
       }
@@ -139,50 +138,48 @@ export class SupabaseSource extends Source {
     for (const op of ops) {
       switch (op.op) {
         case 'addRecord': {
-          const record = await this._addRecord(op.record as InitializedRecord);
+          const record = await this._addRecord(op.record);
           results.push(record);
           break;
         }
         case 'updateRecord': {
-          const record = await this.updateRecord(
-            op.record as InitializedRecord
-          );
+          const record = await this.updateRecord(op.record);
           results.push(record);
           break;
         }
         case 'removeRecord': {
-          await this.removeRecord(op.record as RecordIdentity);
+          await this.removeRecord(op.record);
           break;
         }
         case 'replaceRelatedRecords': {
           await this.replaceRelatedRecords(
-            op.record as RecordIdentity,
-            op.relationship as string,
-            op.relatedRecords as RecordIdentity[]
+            op.record,
+            op.relationship,
+            op.relatedRecords
           );
           break;
         }
         case 'replaceRelatedRecord': {
           await this.replaceRelatedRecord(
-            op.record as RecordIdentity,
-            op.relationship as string,
-            op.relatedRecord as RecordIdentity | null
+            op.record,
+            op.relationship,
+            op.relatedRecord
           );
           break;
         }
         case 'addToRelatedRecords': {
           await this.addToRelatedRecords(
-            op.record as RecordIdentity,
-            op.relationship as string,
-            op.relatedRecord as RecordIdentity
+            op.record,
+            op.relationship,
+            op.relatedRecord
           );
           break;
         }
         case 'removeFromRelatedRecords': {
           await this.removeFromRelatedRecords(
-            op.record as RecordIdentity,
-            op.relationship as string,
-            op.relatedRecord as RecordIdentity
+            op.record,
+            op.relationship,
+            op.relatedRecord
           );
           break;
         }
@@ -215,7 +212,9 @@ export class SupabaseSource extends Source {
 
       if (error) throw new Error(`Supabase query error: ${error.message}`);
 
-      return (data as SupabaseColor[]).map((c) => this.transformColorToOrbit(c));
+      return (data as SupabaseColor[]).map((c) =>
+        this.transformColorToOrbit(c)
+      );
     }
   }
 
@@ -259,7 +258,9 @@ export class SupabaseSource extends Source {
   }
 
   // Add a record (internal implementation)
-  private async _addRecord(record: InitializedRecord): Promise<InitializedRecord> {
+  private async _addRecord(
+    record: InitializedRecord
+  ): Promise<InitializedRecord> {
     const tableName = this.getTableName(record.type);
     const supabaseRecord = this.transformFromOrbit(record);
 
@@ -277,7 +278,9 @@ export class SupabaseSource extends Source {
   }
 
   // Update a record
-  private async updateRecord(record: InitializedRecord): Promise<InitializedRecord> {
+  private async updateRecord(
+    record: InitializedRecord
+  ): Promise<InitializedRecord> {
     const tableName = this.getTableName(record.type);
     const supabaseRecord = this.transformFromOrbit(record);
 
@@ -503,7 +506,9 @@ export class SupabaseSource extends Source {
 }
 
 export default {
-  create(injections: SupabaseSourceInjections = { schema: {} as RecordSchema }) {
+  create(
+    injections: SupabaseSourceInjections = { schema: {} as RecordSchema }
+  ) {
     applyStandardSourceInjections(injections);
 
     injections.name = 'remote';

app/services/data.ts

@@ -5,7 +5,7 @@ import { orbit, type Store } from 'ember-orbit';
 
 import type { Coordinator } from '@orbit/coordinator';
 import type IndexedDBSource from '@orbit/indexeddb';
-import type { InitializedRecord, RecordIdentity } from '@orbit/records';
+import type { InitializedRecord } from '@orbit/records';
 
 import type Palette from '../data-models/palette.ts';
 import type { SupabaseSource } from '../data-sources/remote.ts';

app/services/supabase.ts

@@ -11,6 +11,10 @@ import { createClient } from '@supabase/supabase-js';
 
 import type { EnvironmentConfig } from '../config/environment.ts';
 
+interface Owner {
+  resolveRegistration(name: string): EnvironmentConfig;
+}
+
 export interface SupabaseConfig {
   url: string;
   anonKey: string;
@@ -21,28 +25,30 @@ export default class SupabaseService extends Service {
 
   get client(): SupabaseClient {
     if (!this._client) {
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      const config = (getOwner(this) as any)?.resolveRegistration(
-        'config:environment'
-      ) as EnvironmentConfig;
-      const supabaseConfig = config.supabase;
-
-      if (!supabaseConfig?.url || !supabaseConfig?.anonKey) {
-        throw new Error(
-          'Supabase configuration is missing. Please set SUPABASE_URL and SUPABASE_ANON_KEY.'
-        );
-      }
+      this._initializeClient();
+    }
 
-      this._client = createClient(supabaseConfig.url, supabaseConfig.anonKey, {
-        auth: {
-          autoRefreshToken: true,
-          persistSession: true,
-          detectSessionInUrl: false, // Electron app, no URL detection needed
-        },
-      });
+    return this._client!;
+  }
+
+  private _initializeClient(): void {
+    const owner = getOwner(this) as Owner | undefined;
+    const config = owner?.resolveRegistration('config:environment');
+    const supabaseConfig = config?.supabase;
+
+    if (!supabaseConfig?.url || !supabaseConfig?.anonKey) {
+      throw new Error(
+        'Supabase configuration is missing. Please set SUPABASE_URL and SUPABASE_ANON_KEY.'
+      );
     }
 
-    return this._client;
+    this._client = createClient(supabaseConfig.url, supabaseConfig.anonKey, {
+      auth: {
+        autoRefreshToken: true,
+        persistSession: true,
+        detectSessionInUrl: false, // Electron app, no URL detection needed
+      },
+    });
   }
 
   get auth() {

app/templates/settings/cloud/register.gts

@@ -1,5 +1,3 @@
 import Register from '../../../components/register.gts';
 
-<template>
-  <Register />
-</template>
+<template><Register /></template>