Vox Pidgin language symbol shows up for speakers and doesnt show for non-speakers#6334
Open
Gristlebee wants to merge 2 commits into
Open
Vox Pidgin language symbol shows up for speakers and doesnt show for non-speakers#6334Gristlebee wants to merge 2 commits into
Gristlebee wants to merge 2 commits into
Conversation
Contributor
|
I opened a similar pr (#6333) but your explanation is better so i'll close mine |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Title
Why It's Good For The Game
The current implementation where the language symbol doesn't show for fluent speakers isn't very intuitive in practice. It's fairly easy to mix up what you're speaking when it appears to be plain text in your text box without a symbol. It also makes it consistent with the other languages.
Changelog
🆑
add: Vox pidgin symbol shows for people for understand the language.
/:cl: