Remove errexit from extension patches [skip ci]

Author: shivammathur

scripts/install-extension.sh

@@ -1,5 +1,4 @@
 #!/usr/bin/env bash
-set -e
 
 extension=$1
 repo=$2
@@ -37,6 +36,7 @@ get_latest_git_tag() {
   if [ -z "$latest_tag" ]; then
     repo_owner="${repo_slug%%/*}"
     repo_name="${repo_slug##*/}"
+    # shellcheck disable=SC2016
     graph_query='query($owner:String!,$name:String!){repository(owner:$owner,name:$name){refs(refPrefix:"refs/tags/",first:1,orderBy:{field:TAG_COMMIT_DATE,direction:DESC}){nodes{name}}}}'
     latest_tag=$(gh api graphql -f owner="$repo_owner" -f name="$repo_name" -f query="$graph_query" --jq '.data.repository.refs.nodes[0].name' 2>/dev/null || true)
   fi
@@ -82,7 +82,7 @@ download_latest_pecl_archive() {
 }
 
 if [[ "$repo" != "pecl" && "$tag" = "latest" ]]; then
-  tag="$(get_latest_git_tag "$repo")"
+  tag="$(get_latest_git_tag "$repo")" || exit 1
 fi
 
 # Clean stale sources from previous local builds of the same extension.
@@ -92,34 +92,35 @@ rm -rf /tmp/"$extension"-* /tmp/"$pecl_package"-* /tmp/"$extension".tar.gz "$ext
 if [ "$repo" = "pecl" ]; then
   "$PHP_INSTALL_ROOT"/usr/bin/pecl channel-update pecl.php.net || true
   if [ -n "${tag// }" ]; then
-    "$PHP_INSTALL_ROOT"/usr/bin/pecl download "$pecl_package-$tag" || compgen -G "$pecl_package*.tgz" >/dev/null
+    "$PHP_INSTALL_ROOT"/usr/bin/pecl download "$pecl_package-$tag" || compgen -G "$pecl_package*.tgz" >/dev/null || exit 1
   else
-    "$PHP_INSTALL_ROOT"/usr/bin/pecl download "$pecl_package" || compgen -G "$pecl_package*.tgz" >/dev/null || download_latest_pecl_archive
+    "$PHP_INSTALL_ROOT"/usr/bin/pecl download "$pecl_package" || compgen -G "$pecl_package*.tgz" >/dev/null || download_latest_pecl_archive || exit 1
   fi
-  mv "$pecl_package"*.tgz /tmp/"$extension".tar.gz
+  mv "$pecl_package"*.tgz /tmp/"$extension".tar.gz || exit 1
 else
-  download_git_archive
+  download_git_archive || exit 1
 fi
 
 # Extract it to /tmp and build the extension in INSTALL_ROOT
-tar xf "/tmp/$extension.tar.gz" -C /tmp
+tar xf "/tmp/$extension.tar.gz" -C /tmp || exit 1
 (
   if [ "$repo" = "pecl" ]; then
     cd /tmp/"$pecl_package"-* || exit 1
   else
     tag=${tag#v}
     cd /tmp/"$(basename "$repo")"-"${tag/\//-}" || exit 1
   fi
-  export SED=$(command -v sed)
+  SED=$(command -v sed) || exit 1
+  export SED
   configure_legacy_extension_flags
   if declare -f "patch_${extension}" >/dev/null; then
     "patch_${extension}"
   fi
-  phpize
-  ./configure "--with-php-config=/usr/bin/php-config" "${params[@]}"
-  make -j"$(nproc)"
-  make install
+  phpize || exit 1
+  ./configure "--with-php-config=/usr/bin/php-config" "${params[@]}" || exit 1
+  make -j"$(nproc)" || exit 1
+  make install || exit 1
   # shellcheck disable=SC2097
   # shellcheck disable=SC2098
-  INSTALL_ROOT="$INSTALL_ROOT" make install DESTDIR="$INSTALL_ROOT"
-)
+  INSTALL_ROOT="$INSTALL_ROOT" make install DESTDIR="$INSTALL_ROOT" || exit 1
+) || exit 1