testing [skip ci]

Author: shivammathur

__tests__/utils.test.ts

@@ -177,9 +177,9 @@ describe('Utils tests', () => {
   });
 
   it('checking suppressOutput', async () => {
-    expect(await utils.suppressOutput('win32')).toEqual(' >$null 2>&1');
-    expect(await utils.suppressOutput('linux')).toEqual(' >/dev/null 2>&1');
-    expect(await utils.suppressOutput('darwin')).toEqual(' >/dev/null 2>&1');
+    expect(await utils.suppressOutput('win32')).toEqual(' ');
+    expect(await utils.suppressOutput('linux')).toEqual(' ');
+    expect(await utils.suppressOutput('darwin')).toEqual(' ');
     expect(await utils.suppressOutput('openbsd')).toContain(
       'Platform openbsd is not supported'
     );

dist/index.js

@@ -17,7 +17,7 @@ export async function addINIValuesUnix(
   return (
     'echo "' +
     ini_values.join('\n') +
-    '" | sudo tee -a "${pecl_file:-${ini_file[@]}}" >/dev/null 2>&1' +
+    '" | sudo tee -a "${pecl_file:-${ini_file[@]}}" ' +
     script
   );
 }

src/config.ts

@@ -13,9 +13,9 @@ handle_dependency_extensions() {
   suffix="$(get_php_formula_suffix)"
   if [[ -n "$suffix" ]]; then
     brew_opts=(-sf)
-    patch_abstract_file >/dev/null 2>&1
+    patch_abstract_file 
     for dependency_extension in "${dependency_extensions[@]}"; do
-        brew install "${brew_opts[@]}" "$ext_tap/$dependency_extension@$version" >/dev/null 2>&1 && copy_brew_extensions "$dependency_extension"
+        brew install "${brew_opts[@]}" "$ext_tap/$dependency_extension@$version"  && copy_brew_extensions "$dependency_extension"
     done
   fi
 }
@@ -31,7 +31,7 @@ disable_extension_helper() {
   sudo sed -Ei '' "/=(.*\/)?\"?$extension(.so)?$/d" "${ini_file:?}"
   sudo rm -rf "$scan_dir"/*"$extension"* /tmp/php"$version"_extensions
   mkdir -p /tmp/extdisabled/"$version"
-  echo '' | sudo tee /tmp/extdisabled/"$version"/"$extension" >/dev/null 2>&1
+  echo '' | sudo tee /tmp/extdisabled/"$version"/"$extension" 
 }
 
 # Function to get extension name from brew formula.
@@ -70,9 +70,9 @@ add_brew_extension() {
     add_brew_tap "$php_tap"
     add_brew_tap "$ext_tap"
     sudo mv "$tap_dir"/"$ext_tap"/.github/deps/"$formula"/* "${core_repo:?}/Formula/" 2>/dev/null || true
-    update_dependencies >/dev/null 2>&1
-    handle_dependency_extensions "$formula" "$extension" >/dev/null 2>&1
-    (brew install "${brew_opts[@]}" "$ext_tap/$formula@$version" >/dev/null 2>&1 && copy_brew_extensions "$formula") || pecl_install "$extension" >/dev/null 2>&1
+    update_dependencies 
+    handle_dependency_extensions "$formula" "$extension" 
+    (brew install "${brew_opts[@]}" "$ext_tap/$formula@$version"  && copy_brew_extensions "$formula") || pecl_install "$extension" 
     add_extension_log "$extension" "Installed and enabled"
   fi
 }
@@ -81,7 +81,7 @@ add_brew_extension() {
 patch_abstract_file() {
     abstract_path="$tap_dir"/"$ext_tap"/Abstract/abstract-php-extension.rb
     if [[ -e "$abstract_path" && ! -e /tmp/abstract_patch ]]; then
-        echo '' | sudo tee /tmp/abstract_patch >/dev/null 2>&1
+        echo '' | sudo tee /tmp/abstract_patch 
         sudo sed -i '' -e "s|php@#{\(.*\)}|php@#{\1}$suffix|g" -e "s|php_version /|\"#{php_version}$suffix\" /|g" "$abstract_path"
     fi
 }
@@ -91,9 +91,9 @@ add_extension_helper() {
   local extension=$1
   prefix=$2
   if [[ "$version" =~ ${old_versions:?} ]] && [ "$extension" = "imagick" ]; then
-    run_script "php5-darwin" "${version/./}" "$extension" >/dev/null 2>&1
+    run_script "php5-darwin" "${version/./}" "$extension" 
   else
-    pecl_install "$extension" >/dev/null 2>&1 &&
+    pecl_install "$extension"  &&
     if [[ "$version" =~ ${old_versions:?} ]]; then echo "$prefix=$ext_dir/$extension.so" >>"$ini_file"; fi
   fi
   add_extension_log "$extension" "Installed and enabled"
@@ -107,8 +107,8 @@ add_devtools() {
 
 # Function to handle request to add PECL.
 add_pecl() {
-  enable_extension xml extension >/dev/null 2>&1
-  configure_pecl >/dev/null 2>&1
+  enable_extension xml extension 
+  configure_pecl 
   pear_version=$(get_tool_version "pecl" "version")
   add_log "${tick:?}" "PECL" "Found PECL $pear_version"
 }
@@ -138,7 +138,7 @@ update_dependencies() {
     for repo in "$brew_repo" "$core_repo"; do
       git_retry -C "$repo" fetch origin master && git -C "$repo" reset --hard origin/master
     done
-    echo '' | sudo tee /tmp/update_dependencies >/dev/null 2>&1
+    echo '' | sudo tee /tmp/update_dependencies 
   fi
 }
 
@@ -196,7 +196,7 @@ add_php_config() {
   if [[ "$ini" = "production" || "$ini" = "development" ]]; then
     sudo cp "$ini_dir"/php.ini-"$ini" "$ini_dir"/php.ini
   elif [ "$ini" = "none" ]; then
-    echo '' | sudo tee "${ini_file[@]}" >/dev/null 2>&1
+    echo '' | sudo tee "${ini_file[@]}" 
   fi
 }
 
@@ -217,14 +217,14 @@ setup_php() {
   check_pre_installed
   existing_version=$(get_brewed_php)
   if [[ "$version" =~ ${old_versions:?} ]]; then
-    run_script "php5-darwin" "${version/./}" >/dev/null 2>&1
+    run_script "php5-darwin" "${version/./}" 
     status="Installed"
   elif [ "$existing_version" != "$version" ]; then
-    add_php "install" "$existing_version" >/dev/null 2>&1
+    add_php "install" "$existing_version" 
     status="Installed"
   elif [ "$existing_version" = "$version" ]; then
     if [ "${update:?}" = "true" ]; then
-      add_php "upgrade" "$existing_version" >/dev/null 2>&1
+      add_php "upgrade" "$existing_version" 
       status="Updated to"
     else
       status="Found"

src/scripts/darwin.sh

@@ -48,7 +48,7 @@ enable_extension() {
     [ -d "$modules_dir" ] && sudo find "$modules_dir" -path "*disabled*$1" -delete
     enable_extension_dependencies "$1" "$2"
     enable_cache_extension_dependencies "$1" "$2"
-    if ! [[ "${version:?}" =~ ${old_versions:?} ]] && command -v phpenmod >/dev/null 2>&1; then
+    if ! [[ "${version:?}" =~ ${old_versions:?} ]] && command -v phpenmod ; then
       sudo sed -Ei "/=(.*\/)?\"?$extension(.so)?\"?$/d" "$pecl_file"
       mod="${ini_dir:?}"/../mods-available/"$1".ini
       if ! [ -e "$mod" ]; then
@@ -57,7 +57,7 @@ enable_extension() {
         [ -n "$mod_priority_line" ] && priority=$(echo "$mod_priority_line" | cut -d'=' -f 2)
         (echo "; priority=$priority"; echo "$2=${ext_dir:?}/$1.so") | sudo tee "$mod" >/dev/null
       fi
-      sudo phpenmod -v "$version" "$1" >/dev/null 2>&1
+      sudo phpenmod -v "$version" "$1" 
     else
       echo "$2=${ext_dir:?}/$1.so" | sudo tee -a "${pecl_file:-${ini_file[@]}}" >/dev/null
     fi
@@ -69,15 +69,15 @@ enable_extensions() {
   local extensions=("$@")
   to_wait=()
   for ext in "${extensions[@]}"; do
-    enable_extension "$ext" extension >/dev/null 2>&1 &
+    enable_extension "$ext" extension  &
     to_wait+=($!)
   done
   wait "${to_wait[@]}"
 }
 
 # Function to get a map of extensions and their dependent shared extensions.
 get_extension_map() {
-  php -d'error_reporting=0' "${src:?}"/scripts/extensions/extension_map.php /tmp/map"$version".orig >/dev/null 2>&1
+  php -d'error_reporting=0' "${src:?}"/scripts/extensions/extension_map.php /tmp/map"$version".orig 
 }
 
 # Function to enable extension dependencies which are also extensions.
@@ -123,7 +123,7 @@ disable_extension() {
 disable_all_shared() {
   get_extension_map
   sudo sed -i.orig -E -e "/^(zend_)?extension\s*=/d" "${ini_file[@]}" "$pecl_file" 2>/dev/null || true
-  sudo find "${ini_dir:-$scan_dir}"/.. -name "*.ini" -not -path "*php.ini" -not -path "*phar.ini" -not -path "*pecl.ini" -not -path "*mods-available*" -delete >/dev/null 2>&1 || true
+  sudo find "${ini_dir:-$scan_dir}"/.. -name "*.ini" -not -path "*php.ini" -not -path "*phar.ini" -not -path "*pecl.ini" -not -path "*mods-available*" -delete  || true
   mkdir -p /tmp/extdisabled/"$version"
   sudo rm -f /tmp/php"$version"_extensions
   sudo find "$ext_dir" -name '*.so' -print0 | xargs -0 -n 1 basename -s .so | xargs -I{} touch /tmp/extdisabled/"$version"/{}
@@ -137,7 +137,7 @@ configure_pecl() {
     for script in pear pecl; do
       sudo "$script" channel-update "$script".php.net
     done
-    echo '' | sudo tee /tmp/pecl_config >/dev/null 2>&1
+    echo '' | sudo tee /tmp/pecl_config 
   fi
 }
 
@@ -175,8 +175,8 @@ get_pecl_version() {
 pecl_install() {
   local extension=$1
   local prefix=${2:-extension}
-  add_pecl >/dev/null 2>&1
-  disable_extension_helper "${extension%-*}" >/dev/null 2>&1
+  add_pecl 
+  disable_extension_helper "${extension%-*}" 
   # Compare version with 8.3 so it runs only on 8.4 and above
   # Install using the source interface as it allows for patching.
   if [[ $(printf "%s\n%s" "${version:?}" "8.3" | sort -V | head -n1) != "$version" ]]; then
@@ -189,11 +189,11 @@ pecl_install() {
     prefix_opts="$(parse_args "$extension" CONFIGURE_PREFIX_OPTS) MAKEFLAGS='-j $cpu_count'"
     suffix_opts="$(parse_args "$extension" CONFIGURE_OPTS) $(parse_args "$extension" CONFIGURE_SUFFIX_OPTS)"
     IFS=' ' read -r -a libraries <<<"$(parse_args "$extension" LIBS) $(parse_args "$extension" "$(uname -s)"_LIBS)"
-    (( ${#libraries[@]} )) && add_libs "${libraries[@]}" >/dev/null 2>&1
+    (( ${#libraries[@]} )) && add_libs "${libraries[@]}" 
     if [ "$version" = "5.3" ]; then
-      yes '' 2>/dev/null | sudo "$prefix_opts" pecl install -f "$extension" >/dev/null 2>&1
+      yes '' 2>/dev/null | sudo "$prefix_opts" pecl install -f "$extension" 
     else
-      yes '' 2>/dev/null | sudo "$prefix_opts" pecl install -f -D "$(parse_pecl_configure_options "$suffix_opts")" "$extension" >/dev/null 2>&1
+      yes '' 2>/dev/null | sudo "$prefix_opts" pecl install -f -D "$(parse_pecl_configure_options "$suffix_opts")" "$extension" 
     fi
     local exit_code=$?
     sudo pecl info "$extension" | grep -iq 'zend extension' && prefix=zend_extension
@@ -216,7 +216,7 @@ add_pecl_extension() {
     add_log "${tick:?}" "$extension" "Enabled"
   else
     [ -n "$pecl_version" ] && pecl_version="-$pecl_version"
-    pecl_install "$extension$pecl_version" || add_extension "$extension" "$(get_extension_prefix "$extension")" >/dev/null 2>&1
+    pecl_install "$extension$pecl_version" || add_extension "$extension" "$(get_extension_prefix "$extension")" 
     extension_version="$(php -r "echo phpversion('$extension');")"
     [ -n "$extension_version" ] && extension_version="-$extension_version"
     add_extension_log "$extension$extension_version" "Installed and enabled"

src/scripts/extensions/add_extensions.sh

@@ -19,11 +19,11 @@ add_blackfire() {
         extension_version=$(get -s -n "" https://blackfire.io/api/v1/releases | grep -Eo 'php":"([0-9]+.[0-9]+.[0-9]+)' | cut -d '"' -f 3)
       fi
     fi
-    get -q -n "${ext_dir:?}/blackfire.so" https://packages.blackfire.io/binaries/blackfire-php/"$extension_version"/blackfire-php-"$platform"_"$arch_name"-php-"$no_dot_version".so >/dev/null 2>&1
+    get -q -n "${ext_dir:?}/blackfire.so" https://packages.blackfire.io/binaries/blackfire-php/"$extension_version"/blackfire-php-"$platform"_"$arch_name"-php-"$no_dot_version".so 
   fi
   if [ -e "${ext_dir:?}/blackfire.so" ]; then
-    disable_extension xdebug >/dev/null 2>&1
-    disable_extension pcov >/dev/null 2>&1
+    disable_extension xdebug 
+    disable_extension pcov 
     enable_extension blackfire extension
     add_extension_log blackfire "$status"
   else

src/scripts/extensions/blackfire.sh

@@ -59,9 +59,9 @@ add_couchbase() {
       ext=$(get_couchbase_version)
     fi
     if [[ "$ext" =~ couchbase-[2-3].+ ]]; then
-      add_couchbase_clibs "$ext" >/dev/null 2>&1
+      add_couchbase_clibs "$ext" 
     else
-      add_couchbase_cxxlibs >/dev/null 2>&1
+      add_couchbase_cxxlibs 
     fi
     enable_extension "couchbase" "extension"
     if check_extension "couchbase"; then
@@ -72,9 +72,9 @@ add_couchbase() {
         n_proc="$(nproc)"
         export COUCHBASE_SUFFIX_OPTS="CMAKE_BUILD_TYPE=Release"
         export CMAKE_BUILD_PARALLEL_LEVEL="$n_proc"
-        add_extension_from_source couchbase https://pecl.php.net couchbase couchbase "${ext##*-}" extension pecl >/dev/null 2>&1
+        add_extension_from_source couchbase https://pecl.php.net couchbase couchbase "${ext##*-}" extension pecl 
       else
-        pecl_install "${ext}" >/dev/null 2>&1
+        pecl_install "${ext}" 
       fi
       add_extension_log "couchbase" "Installed and enabled"
     fi

src/scripts/extensions/couchbase.sh

@@ -51,7 +51,7 @@ add_cubrid_helper() {
 add_cubrid() {
   ext=$1
   status='Enabled'
-  add_cubrid_helper "$ext" >/dev/null 2>&1
+  add_cubrid_helper "$ext" 
   add_extension_log "$ext" "$status"
   check_extension "$ext" && add_license_log
 }

src/scripts/extensions/cubrid.sh

@@ -39,9 +39,9 @@ add_event() {
     add_log "${tick:?}" "event" "Enabled"
   else
     if ! [[ "${version:?}" =~ ${old_versions:?} ]] && [ "$os" = "Darwin" ]; then
-      add_brew_extension event extension >/dev/null 2>&1
+      add_brew_extension event extension 
     else
-      add_event_helper "$ext" >/dev/null 2>&1
+      add_event_helper "$ext" 
     fi
     add_extension_log "event" "Installed and enabled"
   fi

src/scripts/extensions/event.sh

@@ -24,20 +24,20 @@ add_firebird_helper() {
 
 add_firebird() {
   if [ "$(uname -s )" = "Darwin" ]; then
-    add_firebird_client_darwin >/dev/null 2>&1
+    add_firebird_client_darwin 
   fi
   enable_extension pdo_firebird extension
   status="Enabled"
   if ! check_extension pdo_firebird; then
     status="Installed and enabled"
     if [ "$(uname -s)" = "Linux" ]; then
       if [[ "${version:?}" =~ 5.3|${nightly_versions:?} ]]; then
-        add_firebird_helper /usr >/dev/null 2>&1
+        add_firebird_helper /usr 
       else
-        add_pdo_extension firebird >/dev/null 2>&1
+        add_pdo_extension firebird 
       fi
     else
-      add_firebird_helper /opt/firebird >/dev/null 2>&1
+      add_firebird_helper /opt/firebird 
     fi
   fi
   add_extension_log pdo_firebird "$status"