Bump Nightly Versions to exclude PHP 8.3 and PHP 8.4#1014
Closed
Sn0wCrack wants to merge 3 commits intoshivammathur:developfrom
Closed
Bump Nightly Versions to exclude PHP 8.3 and PHP 8.4#1014Sn0wCrack wants to merge 3 commits intoshivammathur:developfrom
Sn0wCrack wants to merge 3 commits intoshivammathur:developfrom
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 5 to 6. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…hub_actions/develop/actions/setup-node-6 Bump actions/setup-node from 5 to 6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1014 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 822 822
Branches 286 288 +2
=========================================
Hits 822 822 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shivammathur
force-pushed
the
develop
branch
6 times, most recently
from
7a66e5b to
ae0a506
Compare
shivammathur
force-pushed
the
develop
branch
6 times, most recently
from
2cc968b to
865d464
Compare
Owner
|
Closing in favor of 248e3ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on self-hosted Ubuntu runners that no matter what the PHP Builder script is always used for PHP 8.3 and PHP 8.4, despite them being available via the
ondrej/phpPPA.I tracked this back to the the Nightly Versions regex matching against PHP 8.3 and PHP 8.4
I don't believe there is any reason for these versions to need to be built from source currently.
I have run this against my own self-hosted Ubuntu runners and there does not appear to be any side affects.
Description
This PR updates then nightly version regex to only target PHP 8.5 and up.