Skip to content

Commit 9900277

Browse files
committed
Fix flakyness of testTwoBadUrl
1 parent 2601886 commit 9900277

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

cronet/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ dependencies {
5858

5959
task javadocs(type: Javadoc) {
6060
source = android.sourceSets.main.java.srcDirs
61-
// classpath += files(android.getBootClasspath())
61+
classpath += files(android.getBootClasspath())
6262
classpath += files({
6363
android.libraryVariants.collect { variant ->
6464
variant.javaCompileProvider.get().classpath

xds/src/main/java/io/grpc/xds/client/XdsClientImpl.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1028,7 +1028,11 @@ public void handleStreamClosed(Status status, boolean shouldTryFallback) {
10281028
for (Map<String, ResourceSubscriber<? extends ResourceUpdate>> subscriberMap :
10291029
resourceSubscribers.values()) {
10301030
for (ResourceSubscriber<? extends ResourceUpdate> subscriber : subscriberMap.values()) {
1031-
if (subscriber.hasResult() || !authoritiesForClosedCpc.contains(subscriber.authority)) {
1031+
if (!authoritiesForClosedCpc.contains(subscriber.authority)) {
1032+
continue;
1033+
}
1034+
// If subscriber already has data, this is an ambient error.
1035+
if (subscriber.hasResult()) {
10321036
subscriber.onError(status, null);
10331037
continue;
10341038
}

0 commit comments

Comments
 (0)