Fix coding standard violations (#4686)

Author: grossmannmartin

src/Command/CronCommand.php

@@ -282,7 +282,7 @@ protected function getCronTimeZone(): DateTimeZone
     {
         /** @var string|null $cronTimezone */
         $cronTimezone = $this->parameterBag->get('shopsys.cron_timezone');
-        $cronTimezone = $cronTimezone ?? date_default_timezone_get();
+        $cronTimezone ??= date_default_timezone_get();
 
         return new DateTimeZone($cronTimezone);
     }

src/Component/Cron/MonitorConfigFactory.php

@@ -28,7 +28,7 @@ public function create(CronModuleConfig $cronModuleConfig): MonitorConfig
             $maxRuntime = (int)ceil($cronModuleConfig->getTimeoutIteratedCronSec() / 60);
         }
 
-        $maxRuntime = $maxRuntime ?? self::DEFAULT_MAX_RUNTIME_MIN;
+        $maxRuntime ??= self::DEFAULT_MAX_RUNTIME_MIN;
 
         $checkinMargin = $sentryMonitorConfig?->getCheckinMargin() ?? $cronModuleConfig->getRunEveryMin();
 

src/Component/EntityLog/ChangeSet/ChangeSetResolver.php

@@ -40,7 +40,7 @@ protected function registerDataTypeResolvers(iterable $dataTypeResolvers): void
             $dataTypeResolversArray[] = $dataTypeResolver;
         }
 
-        //sort data type resolvers from higher to lower priority
+        // sort data type resolvers from higher to lower priority
         usort($dataTypeResolversArray, function (DataTypeResolverInterface $a, DataTypeResolverInterface $b) {
             return $b->getPriority() - $a->getPriority();
         });

src/Component/EntityLog/EventListener/EntityLogEventListener.php

@@ -126,7 +126,7 @@ protected function resolveUpdateChangeSet(object $entity): array
 
         foreach ($changeSet as $key => $value) {
             if ($value instanceof PersistentCollection) {
-                unset($changeSet[$key]); //collection is logged in resolveChangesOnCollectionForEntity method
+                unset($changeSet[$key]); // collection is logged in resolveChangesOnCollectionForEntity method
             }
         }
 

src/Component/FlashMessage/FlashMessageTrait.php

@@ -8,7 +8,7 @@
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\NotFoundExceptionInterface;
 use Symfony\Component\HttpFoundation\Exception\SessionNotFoundException;
-use Symfony\Component\HttpFoundation\Session\Session as Session;
+use Symfony\Component\HttpFoundation\Session\Session;
 
 /**
  * @property \Psr\Container\ContainerInterface $container

src/Migrations/Version20241205144230.php

@@ -13,17 +13,17 @@ final class Version20241205144230 extends AbstractMigration
     #[Override]
     public function up(Schema $schema): void
     {
-        //product indexes
+        // product indexes
         $this->sql('CREATE INDEX products_catnum_trgm_idx ON products USING gin (normalized(catnum) gin_trgm_ops);');
         $this->sql('CREATE INDEX products_partno_trgm_idx ON products USING gin (normalized(partno) gin_trgm_ops);');
         $this->sql('CREATE INDEX product_translations_name_trgm_idx ON product_translations USING gin (normalized(name) gin_trgm_ops);');
 
-        //order indexes
+        // order indexes
         $this->sql('CREATE INDEX orders_email_trgm_idx ON orders USING gin (normalized(email) gin_trgm_ops);');
         $this->sql('CREATE INDEX orders_last_name_trgm_idx ON orders USING gin (normalized(last_name) gin_trgm_ops);');
         $this->sql('CREATE INDEX orders_company_name_trgm_idx ON orders USING gin (normalized(company_name) gin_trgm_ops);');
 
-        //user indexes
+        // user indexes
         $this->sql('CREATE INDEX customer_users_email_trgm_idx ON customer_users USING gin (normalized(email) gin_trgm_ops);');
         $this->sql('CREATE INDEX customer_users_last_name_trgm_idx ON customer_users USING gin (normalized(last_name) gin_trgm_ops);');
         $this->sql('CREATE INDEX customer_users_telephone_trgm_idx ON customer_users USING gin (normalized(telephone) gin_trgm_ops);');

src/Model/Administrator/Security/AdministratorUserProvider.php

@@ -87,8 +87,8 @@ public function refreshUser(UserInterface $userInterface): UserInterface
         }
 
         if ($freshAdministrator->getRolesChangedAt() > $administrator->getRolesChangedAt()) {
-            //In this step token does not exist, so we are not able to update user roles.
-            //We notify RolesChangedListener for roles updating
+            // In this step token does not exist, so we are not able to update user roles.
+            // We notify RolesChangedListener for roles updating
             $this->administratorRolesChangedSubscriber->updateRoles();
         }
 

src/Model/Category/CategoryRepository.php

@@ -466,7 +466,7 @@ public function getCategoryNamesInPathFromRootToProductMainCategoryOnDomain(
     ): array {
         $queryBuilder = $this->getAllQueryBuilder();
         $domainId = $domainConfig->getId();
-        $locale = $locale ?? $domainConfig->getLocale();
+        $locale ??= $domainConfig->getLocale();
         $mainCategory = $this->getProductMainCategoryOnDomain($product, $domainId);
 
         $this->addTranslation($queryBuilder, $locale);

src/Model/Customer/User/Role/CustomerUserRoleSectionProvider.php

@@ -22,7 +22,7 @@ protected function defineSections(): void
     }
 
     /**
-     * @{inheritDoc}
+     * {@inheritdoc}
      */
     #[Override]
     public static function getTargetContext(): string

src/Model/Order/Processing/OrderProcessorMiddleware/PersonalPickupPointMiddleware.php

@@ -64,10 +64,10 @@ protected function updateDeliveryDataByStore(OrderData $orderData, Store $store)
         $orderData->personalPickupStore = $store;
         $orderData->deliveryAddressSameAsBillingAddress = false;
 
-        $orderData->deliveryFirstName = $orderData->deliveryFirstName ?? $orderData->firstName;
-        $orderData->deliveryLastName = $orderData->deliveryLastName ?? $orderData->lastName;
-        $orderData->deliveryCompanyName = $orderData->deliveryCompanyName ?? $orderData->companyName;
-        $orderData->deliveryTelephone = $orderData->deliveryTelephone ?? $orderData->telephone;
+        $orderData->deliveryFirstName ??= $orderData->firstName;
+        $orderData->deliveryLastName ??= $orderData->lastName;
+        $orderData->deliveryCompanyName ??= $orderData->companyName;
+        $orderData->deliveryTelephone ??= $orderData->telephone;
 
         $orderData->deliveryStreet = $store->getStreet();
         $orderData->deliveryCity = $store->getCity();