WIP

Author: grossmannmartin

build.xml

@@ -721,7 +721,7 @@
         </exec>
     </target>
 
-    <target name="environment-change" depends="production-protection" description="Change application environment and install composer dev-dependencies when development environment is selected.">
+    <target name="environment-change" depends="production-protection" description="Change application environment and install Composer and NPM dependencies for the selected environment.">
         <if>
             <not><isset property="change.environment"/></not>
             <then>
@@ -752,11 +752,12 @@
                 </exec>
             </else>
         </if>
+        <phingcall target="npm-install-dependencies"/>
         <phingcall target="clean-cache"/>
         <phingcall target="maintenance-off"/>
     </target>
 
-    <target name="environment-change-prod" description="Change application environment to production and install production composer dependencies.">
+    <target name="environment-change-prod" description="Change application environment to production and install production dependencies.">
         <property name="change.environment" value="prod"/>
         <phingcall target="environment-change"/>
     </target>
@@ -901,6 +902,7 @@
         <exec executable="/bin/sh" logoutput="true" passthru="true" checkreturn="true">
             <arg value="${path.framework}/scripts/npm-install-with-retry.sh"/>
             <arg value="${path.npm.executable}"/>
+            <arg value="${path.root}"/>
         </exec>
     </target>
 
@@ -1058,9 +1060,9 @@
         </if>
     </target>
 
-    <target name="standards" depends="phplint,ecs,markdown-check,annotations-check,phpstan,twig-lint,yaml-standards,js-standards-check" description="Checks coding standards."/>
+    <target name="standards" depends="phplint,ecs,markdown-check,annotations-check,phpstan,twig-lint,yaml-standards,js-standards-check,stylelint" description="Checks coding standards."/>
 
-    <target name="standards-diff" depends="phplint-diff,ecs-diff,markdown-check,annotations-check,phpstan,twig-lint-diff,yaml-standards,js-standards-check" description="Checks coding standards in changed files."/>
+    <target name="standards-diff" depends="phplint-diff,ecs-diff,markdown-check,annotations-check,phpstan,twig-lint-diff,yaml-standards,js-standards-check,stylelint" description="Checks coding standards in changed files."/>
 
     <target name="standards-fix" depends="ecs-fix,markdown-fix,annotations-fix,yaml-standards-fix,js-standards-fix,ux-icons-lock" description="Automatically fixes *some* coding standards violations in all files. Always run 'standards' to be sure there are no further violations."/>
 

scripts/npm-install-with-retry.sh

@@ -3,10 +3,19 @@
 set -e
 
 npm_executable="${1:-npm}"
+application_root="${2:-.}"
 max_attempts=5
 
+install_dependencies() {
+    if [ -f "$application_root/DEVELOPMENT" ] || [ -f "$application_root/TEST" ] || [ -f "$application_root/ACCEPTANCE" ]; then
+        "$npm_executable" install --install-links
+    else
+        "$npm_executable" install --omit=dev
+    fi
+}
+
 for attempt in 1 2 3 4 5; do
-    if "$npm_executable" install; then
+    if install_dependencies; then
         exit 0
     fi