broaden protected-visibility rule to all Shopsys code (#4618)

Author: vitek-rostislav

src/Auth/BasicHttpAuth.php

@@ -7,7 +7,7 @@
 use Override;
 use Symfony\Component\HttpFoundation\Request;
 
-class BasicHttpAuth implements AuthInterface
+final class BasicHttpAuth implements AuthInterface
 {
     public function __construct(private string $username, private ?string $password = null)
     {

src/RequestDataSet.php

@@ -9,7 +9,7 @@
 use Shopsys\HttpSmokeTesting\Auth\NoAuth;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
-class RequestDataSet implements RequestDataSetConfig
+final class RequestDataSet implements RequestDataSetConfig
 {
     private const DEFAULT_EXPECTED_STATUS_CODE = 200;
 

src/RequestDataSetGenerator.php

@@ -10,14 +10,14 @@
 
 class RequestDataSetGenerator implements RouteConfig
 {
-    private RequestDataSet $defaultRequestDataSet;
+    protected RequestDataSet $defaultRequestDataSet;
 
     /**
      * @var \Shopsys\HttpSmokeTesting\RequestDataSet[]
      */
-    private array $extraRequestDataSets;
+    protected array $extraRequestDataSets;
 
-    public function __construct(private readonly RouteInfo $routeInfo)
+    public function __construct(protected readonly RouteInfo $routeInfo)
     {
         $this->defaultRequestDataSet = new RequestDataSet($this->routeInfo->getRouteName());
         $this->extraRequestDataSets = [];
@@ -34,7 +34,7 @@ public function fulfillRequestFromAnnotations(): void
         }
     }
 
-    private function getRequestDataSetForIteration(int $index): RequestDataSet
+    protected function getRequestDataSetForIteration(int $index): RequestDataSet
     {
         if ($index === 0) {
             return $this->defaultRequestDataSet;
@@ -43,7 +43,7 @@ private function getRequestDataSetForIteration(int $index): RequestDataSet
         return $this->addExtraRequestDataSet();
     }
 
-    private function fulfillRequestDataSetFromAnnotation(RequestDataSet $requestDataSet, DataSet $annotation): void
+    protected function fulfillRequestDataSetFromAnnotation(RequestDataSet $requestDataSet, DataSet $annotation): void
     {
         if ($annotation->statusCode) {
             $requestDataSet->setExpectedStatusCode($annotation->statusCode);

src/RouteConfigCustomizer.php

@@ -11,7 +11,7 @@ class RouteConfigCustomizer
     /**
      * @param \Shopsys\HttpSmokeTesting\RequestDataSetGenerator[] $requestDataSetGenerators
      */
-    public function __construct(private readonly array $requestDataSetGenerators)
+    public function __construct(protected readonly array $requestDataSetGenerators)
     {
     }
 

src/RouteInfo.php

@@ -6,7 +6,7 @@
 
 use Symfony\Component\Routing\Route;
 
-class RouteInfo
+final class RouteInfo
 {
     public function __construct(
         private string $routeName,

src/RouterAdapter/SymfonyRouterAdapter.php

@@ -17,7 +17,7 @@
 
 class SymfonyRouterAdapter implements RouterAdapterInterface
 {
-    public function __construct(private readonly RouterInterface $router)
+    public function __construct(protected readonly RouterInterface $router)
     {
     }
 
@@ -36,7 +36,7 @@ public function getAllRouteInfo(): array
         return $allRouteInfo;
     }
 
-    private function extractAttributesForRoute(Route $route): array
+    protected function extractAttributesForRoute(Route $route): array
     {
         if ($route->hasDefault('_controller')) {
             return $this->extractAttributesForController($route->getDefault('_controller'));
@@ -45,7 +45,7 @@ private function extractAttributesForRoute(Route $route): array
         return [];
     }
 
-    private function extractAttributesForController(string $controller): array
+    protected function extractAttributesForController(string $controller): array
     {
         try {
             $reflectionMethod = ReflectionMethod::createFromMethodName($controller);
@@ -59,7 +59,7 @@ private function extractAttributesForController(string $controller): array
     /**
      * @return array<\Shopsys\HttpSmokeTesting\Attribute\DataSet|\Shopsys\HttpSmokeTesting\Attribute\Skipped>
      */
-    private function getControllerMethodAttributes(ReflectionMethod $reflectionMethod): array
+    protected function getControllerMethodAttributes(ReflectionMethod $reflectionMethod): array
     {
         $attributes = [];