[WIP] Rewrite action to be docker based without requiring compiled Node.js files#10
Open
Claude wants to merge 10 commits into
Open
[WIP] Rewrite action to be docker based without requiring compiled Node.js files#10Claude wants to merge 10 commits into
Claude wants to merge 10 commits into
Conversation
- Add Dockerfile for building and running the action - Add entrypoint.sh script - Update action.yml to use Docker instead of Node.js - Add .dockerignore to exclude unnecessary files - Update .gitignore to exclude dist directory Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/8afcd7b3-fa00-4d86-8db1-89fc1c727595 Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
The dist directory is no longer needed as the action is now Docker-based and builds inside the container Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/8afcd7b3-fa00-4d86-8db1-89fc1c727595 Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
Add development section explaining Docker-based approach and how to test changes Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/8afcd7b3-fa00-4d86-8db1-89fc1c727595 Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
Git is not needed in the container as GitHub Actions checks out the repository before running the Docker container Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/8afcd7b3-fa00-4d86-8db1-89fc1c727595 Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/25d98925-ef55-4359-9f86-3746fbbaace9 Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
- Removed npm run build from Dockerfile - Added tsx as global dependency for TypeScript execution - Updated entrypoint.sh to run src/index.ts directly - Simplifies Docker image build and removes need for compiled files Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/5a728d56-6d6c-48a5-801f-d943473ecc9c Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
Updated development documentation to clarify that TypeScript is now executed directly with tsx instead of being compiled during Docker build Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/5a728d56-6d6c-48a5-801f-d943473ecc9c Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
- Removed tsx installation from Dockerfile - Updated entrypoint to use node --experimental-strip-types - Updated README to reflect Node.js 24 native TypeScript support - Simplest possible setup: just Node.js running TypeScript directly Agent-Logs-Url: https://github.com/shoptet/pr-test-coverage/sessions/e4cbce2a-9232-409c-aa85-edc8186f105a Co-authored-by: simonjur <118170619+simonjur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.