SG-43835 Fix black pre-commit/CI discrepancy by removing exclude (#1111)

* SG-43835 Fix black pre-commit/CI discrepancy by removing exclude

Remove the `exclude: "tests|python/tank"` override from the black hook
in `.pre-commit-config.yaml` so that local pre-commit runs black on the
same set of files as the CI pipeline. Apply black formatting to the
previously-excluded files to bring them into compliance.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* SG-43835 Apply black 26.5.1 formatting to remaining files

Re-run black at the correct pinned version (26.5.1) to catch files
missed by the initial formatting pass which used an older version.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* SG-43835 Disable black in hound - already enforced by pre-commit CI

Hound runs its own black version which differs from the one pinned in
.pre-commit-config.yaml, causing spurious review comments. Black
formatting is already enforced by the CI pipeline via pre-commit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* SG-43835 Fix black formatting in flowam/open.py

Remove extra blank line before logger assignment flagged by CI's
code-style-validation job.

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: stevelittlefish

.hound.yml

@@ -14,5 +14,8 @@ python:
   enabled: true
   config_file: .flake8
 
+black:
+  enabled: false
+
 rubocop:
   enabled: false

.pre-commit-config.yaml

@@ -57,4 +57,3 @@ repos:
     rev: 26.5.1
     hooks:
     - id: black
-      exclude: "tests|python\/tank"

python/tank/__init__.py

@@ -171,6 +171,6 @@ def __fix_tank_vendor():
 
 # expose the support url
 from .constants import (
-  DEFAULT_STORAGE_ROOT_HOOK_NAME,
-  SUPPORT_URL as support_url,
+    DEFAULT_STORAGE_ROOT_HOOK_NAME,
+    SUPPORT_URL as support_url,
 )

python/tank/api.py

@@ -38,7 +38,7 @@ class Sgtk(object):
     manipulation and the Toolkit template system.
     """
 
-    (DEFAULT, CENTRALIZED, DISTRIBUTED) = range(3)
+    DEFAULT, CENTRALIZED, DISTRIBUTED = range(3)
 
     def __init__(self, project_path):
         """

python/tank/authentication/app_session_launcher.py

@@ -89,7 +89,7 @@ def process(
 
         url_handlers.append(
             urllib.request.HTTPSHandler(
-                context = ssl.create_default_context(
+                context=ssl.create_default_context(
                     cafile=ca_certs,
                 ),
             ),
@@ -255,10 +255,12 @@ def process(
         elif response_code_major == 3:
             location = response.headers.get("location", None)
 
-            logger.debug("Request redirected: http code: {code}; redirect to: {location}".format(
-                code=response.code,
-                location=location,
-            ))
+            logger.debug(
+                "Request redirected: http code: {code}; redirect to: {location}".format(
+                    code=response.code,
+                    location=location,
+                )
+            )
 
             raise AuthenticationError(
                 "Request redirected",
@@ -286,9 +288,11 @@ def process(
             )
 
         elif response.code != http.client.OK:
-            logger.debug("Request denied: http code is: {code}".format(
-                code=response.code,
-            ))
+            logger.debug(
+                "Request denied: http code is: {code}".format(
+                    code=response.code,
+                )
+            )
             raise AuthenticationError(
                 "Request denied",
                 payload=getattr(response, "json", response),
@@ -503,9 +507,11 @@ def build_user_agent():
 
     lh = logging.StreamHandler()
     lh.setLevel(logging.DEBUG)
-    lh.setFormatter(logging.Formatter(
-        "%(asctime)s - %(levelname)s - %(message)s",
-    ))
+    lh.setFormatter(
+        logging.Formatter(
+            "%(asctime)s - %(levelname)s - %(message)s",
+        )
+    )
 
     logger.addHandler(lh)
     print()

python/tank/authentication/constants.py

@@ -22,6 +22,6 @@
 def method_resolve_reverse(m):
     global method_resolve
 
-    for (k, v) in method_resolve.items():
+    for k, v in method_resolve.items():
         if v == m:
             return k

python/tank/authentication/errors.py

@@ -73,9 +73,7 @@ def __init__(self, login):
         """
         :param str login: ``login`` field value of the ``HumanUser`` that could not be resolved.
         """
-        super().__init__(
-            "person", "HumanUser", "login", login
-        )
+        super().__init__("person", "HumanUser", "login", login)
 
 
 class UnresolvableScriptUser(UnresolvableUser):
@@ -87,9 +85,7 @@ def __init__(self, script_name):
         """
         :param str script_name: ``firstname`` field value of the ``ApiUser`` that could not be resolved.
         """
-        super().__init__(
-            "script", "ApiUser", "firstname", script_name
-        )
+        super().__init__("script", "ApiUser", "firstname", script_name)
 
 
 class ConsoleLoginNotSupportedError(ShotgunAuthenticationError):

python/tank/authentication/interactive_authentication.py

@@ -33,7 +33,6 @@
 import os
 from tank.util import is_windows
 
-
 logger = LogManager.get_logger(__name__)
 
 
@@ -78,6 +77,7 @@ def _get_ui_state() -> bool:
 
     return bool(QtGui and QtGui.QApplication.instance())
 
+
 class SessionRenewal(object):
     """
     Handles multi-threaded session renewal. This class handles the use case when
@@ -220,6 +220,7 @@ def renew_session(user):
     # If we have a gui, we need gui based authentication
     if has_ui:
         from .ui_authentication import UiAuthenticationHandler
+
         authenticator = UiAuthenticationHandler(
             is_session_renewal=True, session_metadata=user.get_session_metadata()
         )

python/tank/authentication/login_dialog.py

@@ -17,6 +17,7 @@
 at any point.
 --------------------------------------------------------------------------------
 """
+
 import os
 import sys
 from tank_vendor import shotgun_api3
@@ -109,6 +110,7 @@ def run(self):
         """
         self._site_info.reload(self._url_to_test, self._http_proxy)
 
+
 class LoginDialog(QtGui.QDialog):
     """
     Dialog for getting user credentials.
@@ -494,15 +496,21 @@ def _toggle_web(self, method_selected=None):
             # - they need to use the legacy login / passphrase to use a PAT with
             #   Autodesk Identity authentication
             if os.environ.get("SGTK_FORCE_STANDARD_LOGIN_DIALOG"):
-                logger.info("Using the standard login dialog with the Flow Production Tracking")
+                logger.info(
+                    "Using the standard login dialog with the Flow Production Tracking"
+                )
             else:
                 if _is_running_in_desktop():
-                    can_use_web = can_use_web or self.site_info.autodesk_identity_enabled
+                    can_use_web = (
+                        can_use_web or self.site_info.autodesk_identity_enabled
+                    )
 
                 # If we have full support for Web-based login, or if we enable it in our
                 # environment, use the Unified Login Flow for all authentication modes.
                 if get_shotgun_authenticator_support_web_login():
-                    can_use_web = can_use_web or self.site_info.unified_login_flow_enabled
+                    can_use_web = (
+                        can_use_web or self.site_info.unified_login_flow_enabled
+                    )
 
         if method_selected:
             # Selecting requested mode (credentials, qt_web_login or app_session_launcher)
@@ -514,9 +522,7 @@ def _toggle_web(self, method_selected=None):
             method_selected = session_cache.get_preferred_method(site)
 
         # Make sure that the method_selected is currently supported
-        if (
-            method_selected == auth_constants.METHOD_WEB_LOGIN and not can_use_web
-        ) or (
+        if (method_selected == auth_constants.METHOD_WEB_LOGIN and not can_use_web) or (
             method_selected == auth_constants.METHOD_ASL and not can_use_asl
         ):
             method_selected = None
@@ -528,9 +534,7 @@ def _toggle_web(self, method_selected=None):
             )
 
         # Make sure that the method_selected is currently supported
-        if (
-            method_selected == auth_constants.METHOD_WEB_LOGIN and not can_use_web
-        ) or (
+        if (method_selected == auth_constants.METHOD_WEB_LOGIN and not can_use_web) or (
             method_selected == auth_constants.METHOD_ASL and not can_use_asl
         ):
             method_selected = None
@@ -701,7 +705,9 @@ def result(self):
             "Logged In",
             properties={
                 "authentication_method": self.site_info.user_authentication_method,
-                "authentication_experience": auth_constants.method_resolve.get(self.method_selected),
+                "authentication_experience": auth_constants.method_resolve.get(
+                    self.method_selected
+                ),
                 "authentication_interface": "qt_dialog",
                 "authentication_renewal": self._is_session_renewal,
             },
@@ -770,7 +776,10 @@ def _ok_pressed(self):
 
         # Cleanup the URL and update the GUI.
         if self.method_selected != auth_constants.METHOD_BASIC:
-            if site.startswith("http://") and "SGTK_AUTH_ALLOW_NO_HTTPS" not in os.environ:
+            if (
+                site.startswith("http://")
+                and "SGTK_AUTH_ALLOW_NO_HTTPS" not in os.environ
+            ):
                 site = "https" + site[4:]
             self.ui.site.setEditText(site)
 

python/tank/authentication/session_cache.py

@@ -222,7 +222,7 @@ def _try_load_site_authentication_file(file_path):
     content.setdefault(_RECENT_USERS, [])
 
     if content.get(_PREFERRED_METHOD, "not null") is None:
-        del(content[_PREFERRED_METHOD])
+        del content[_PREFERRED_METHOD]
 
     for user in content[_USERS]:
         user[_LOGIN] = user[_LOGIN].strip()