feat: [SG-43418] Replace env var side channel with show_dialog parameters#141
Draft
chenm1adsk wants to merge 1 commit into
Draft
feat: [SG-43418] Replace env var side channel with show_dialog parameters#141chenm1adsk wants to merge 1 commit into
chenm1adsk wants to merge 1 commit into
Conversation
chenm1adsk
marked this pull request as draft
June 8, 2026 20:07
Base automatically changed from
ticket/SG-43460_migration_4
to
ticket/SG-43458_migration_3
June 10, 2026 18:42
Base automatically changed from
ticket/SG-43458_migration_3
to
ticket/SG-43457_migration_2
June 10, 2026 18:43
Base automatically changed from
ticket/SG-43457_migration_2
to
ticket/SG-43456_migration_1
June 10, 2026 18:45
chenm1adsk
force-pushed
the
ticket/SG-43418-improve-loader-context-propagation
branch
from
July 16, 2026 22:55
3f3a60f to
60f2295
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 18.30% 18.30%
=======================================
Files 32 32
Lines 3070 3070
=======================================
Hits 562 562
Misses 2508 2508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ters
The Loader previously used TK_FLOWAM_REVISION_ID_* environment variables
to pass am_revision_id to the Publisher, which caused race conditions when
multiple Publisher dialogs were open simultaneously.
Replace with clean parameter passing via show_dialog(context, root_item_properties):
- When publishing new generic asset: pass entity_ctx so Publisher can pre-fill the context widget and use task/entity for MEDM hierarchy placement.
- When publishing existing generic asset revision: pass context=None and root_item_properties={"am_revision_id": revision_id} so the publish hook receives the correct asset identifier without env vars or shared state.
chenm1adsk
force-pushed
the
ticket/SG-43418-improve-loader-context-propagation
branch
from
July 20, 2026 20:29
a3f4e6a to
3c5e599
Compare
chenm1adsk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Loader previously used TK_FLOWAM_REVISION_ID_* environment variables
to pass am_revision_id to the Publisher, which caused race conditions when
multiple Publisher dialogs were open simultaneously.
Replace with clean parameter passing via show_dialog(context, root_item_properties):