fix: video-to-mp3 tool hardening + CWV cleanup + YouTube-URL notice#5
Open
musab123-afk wants to merge 2 commits into
Open
fix: video-to-mp3 tool hardening + CWV cleanup + YouTube-URL notice#5musab123-afk wants to merge 2 commits into
musab123-afk wants to merge 2 commits into
Conversation
- index.html: drop duplicate jQuery/Popper/Bootstrap/Google-Fonts (site layout provides them); add post-conversion 'free API key' upsell - app.js: add status .fail() handler, 6-min timeout, real stage-based progress (was infinite poll + fake 90%) - convert.js: reject YouTube/streaming-host + non-http(s) URLs (Ingest cannot fetch these; was an infinite hang) - shotstack.js: fix unhandled promise rejection in status()
Show an inline 'not supported' notice and disable the convert button the moment a YouTube/streaming-host URL is typed, instead of only rejecting it server-side after submit. Client host list mirrors convert.js exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional half of the video-to-mp3 v1 ship (pairs with website-v2 Bitbucket PR #41 for the SEO half).
52a971c — hardening + CWV cleanup
f435ac8 — YouTube URL notice
Scope: tool reliability + CWV only. No GA4/tracking changes. Opened from a fork (no write access to this repo).