Skip to content

Commit 23e4ff1

Browse files
cleanup
1 parent 7e09357 commit 23e4ff1

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

google-apis-core/lib/google/apis/core/storage_upload.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ def initiate_resumable_upload(client)
136136
request_header[CONTENT_LENGTH_HEADER] = upload_io.size.to_s
137137
request_header[CONTENT_TYPE_HEADER] = JSON_CONTENT_TYPE
138138
request_header[UPLOAD_CONTENT_TYPE_HEADER] = upload_content_type unless upload_content_type.nil?
139+
139140
response = client.post(url.to_s, body, request_header) do |request|
140141
request.params.replace(request_query)
141142
end
@@ -175,7 +176,7 @@ def send_upload_command(client)
175176
request_header = header.dup
176177
request_header[CONTENT_RANGE_HEADER] = get_content_range_header current_chunk_size
177178
request_header[CONTENT_LENGTH_HEADER] = current_chunk_size.to_s
178-
last_chunk= remaining_content_size <= current_chunk_size
179+
last_chunk = remaining_content_size <= current_chunk_size
179180
formatted_string = formatted_checksum_header
180181
request_header['X-Goog-Hash'] = formatted_string if (last_chunk && !formatted_string.empty?)
181182

@@ -185,7 +186,9 @@ def send_upload_command(client)
185186
else
186187
StringIO.new(upload_io.read(current_chunk_size))
187188
end
189+
188190
response = client.put(@upload_url, chunk_body, request_header)
191+
189192
result = process_response(response.status.to_i, response.headers, response.body)
190193
@upload_incomplete = false if response.status.to_i.eql? OK_STATUS
191194
@offset += current_chunk_size if @upload_incomplete
@@ -248,6 +251,7 @@ def cancel_resumable_upload(client)
248251

249252
def handle_resumable_upload_http_response_codes(response)
250253
code = response.status.to_i
254+
251255
case code
252256
when 308
253257
if response.headers['Range']

google-apis-core/spec/google/apis/core/storage_upload_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,7 @@
117117

118118
before(:example) do
119119
stub_request(:put, 'https://www.googleapis.com/zoo/animals')
120-
.with(headers: {
121-
'Content-Range' => 'bytes 11-21/22'
122-
})
120+
.with(headers: { 'Content-Range' => 'bytes 11-21/22'})
123121
.to_return(body: %(OK))
124122
end
125123

0 commit comments

Comments
 (0)