adding tests

Author: shubhangi-google

google-apis-core/spec/google/apis/core/service_spec.rb

@@ -16,6 +16,7 @@
 require 'google/apis/options'
 require 'google/apis/core/base_service'
 require 'google/apis/core/json_representation'
+require 'pry'
 
 RSpec.describe Google::Apis::Core::BaseService do
   include TestHelpers
@@ -287,6 +288,24 @@
         expect(a_request(:put, upload_url)).to have_been_made
       end
     end
+    context 'Should return false if wrong upload id is provided' do
+      let(:upload_id) { 'wrong_id' }
+      let(:command) do
+        service.send(
+          :restart_resumable_upload,
+          bucket_name, file, upload_id,
+          options: { upload_chunk_size: 11}
+        )
+      end
+      before(:example) do
+        stub_request(:put, upload_url)
+          .to_return(status: 404)
+      end
+      it 'should return false' do
+        expect(command).to be_falsey
+      end
+    end
+
   end
 
   context 'delete resumable upload with upload_id' do
@@ -312,6 +331,24 @@
       expect(a_request(:delete, upload_url)).to have_been_made
       expect(command).to be_truthy
     end
+
+    context 'Should return false if wrong upload id is provided' do
+      let(:upload_id) { 'wrong_id' }
+      let(:command) do
+      service.send(
+        :delete_resumable_upload,
+        bucket_name, upload_id,
+        options: { upload_chunk_size: 11}
+      )
+    end
+      before(:example) do
+        stub_request(:delete, upload_url)
+          .to_return(status: 404)
+      end
+      it 'should return false' do
+        expect(command).to be_falsey
+      end
+    end
   end
 
   context 'with batch' do

google-apis-core/spec/google/apis/core/storage_upload_spec.rb

@@ -161,6 +161,14 @@
       expect(a_request(:put, upload_url)
         .with(body: 'Hello world')).to have_been_made
     end
+
+    it 'should return false if wrong upload id is provided' do
+      stub_request(:put, upload_url)
+        .to_return(status: 404)
+      command.options.upload_chunk_size = 11
+      command.upload_id = upload_id
+      expect(command.execute(client)).to be_falsy
+    end
   end
 
   context('should not restart resumable upload if upload is completed') do
@@ -235,6 +243,15 @@
       expect(a_request(:put, upload_url)
         .with(body: 'Hello world')).to have_not_been_made
     end
+
+    it 'should return false if wrong upload id is provided' do
+      stub_request(:delete, upload_url)
+        .to_return(status: 404)
+      command.options.upload_chunk_size = 11
+      command.upload_id = upload_id
+      command.delete_upload = true
+      expect(command.execute(client)).to be_falsy
+    end
   end
 
   context('with chunking disabled') do